Issue 1999273002: fix performance of setType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1999273002: fix performance of setType (Closed)

Created:
4 years, 7 months ago by Jennifer Messerly

Modified:
4 years, 7 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

fix performance of setType it was mutating the class (e.g. JSArray<int>) every time an instance was constructed (!) R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/c0ee1e56379f640aab851c1fa611bb1996106368

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -28 lines)			Patch
M	lib/runtime/dart_sdk.js	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	lib/src/compiler/code_generator.dart	View	3 chunks	+10 lines, -15 lines	0 comments	Download
M	tool/input_sdk/private/ddc_runtime/classes.dart	View	1 chunk	+15 lines, -11 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

4 years, 7 months ago (2016-05-21 00:46:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c0ee1e56379f640aab851c1fa611bb1996106368 (presubmit successful).