Add Xlib support to viewer

Add Xlib support to viewer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1999213002

Committed: https://skia.googlesource.com/skia/+/1d1559620058365e0de25636f1bcf07fcc071c3d

[jvanverth1, 2016-05-20 19:51:16]

Description was changed from

==========
Add Xlib support to viewer

BUG=skia:
==========

to

==========
Add Xlib support to viewer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1999213002
==========

[jvanverth1, 2016-05-23 17:48:45]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com, djsollen@google.com

[jvanverth1, 2016-05-23 17:48:46]

This is basically working, though I think it could use a little TLC from someone
who knows X better than I do. I still have to incorporate Yuqian's change and
add OpenGL support.

[bsalomon, 2016-05-23 17:54:59]

lgtm, did you make sure nanobench still works on linux?

https://codereview.chromium.org/1999213002/diff/60001/include/gpu/vk/GrVkDefi...
File include/gpu/vk/GrVkDefines.h (left):

https://codereview.chromium.org/1999213002/diff/60001/include/gpu/vk/GrVkDefi...
include/gpu/vk/GrVkDefines.h:27: // Xlib.h may define these macros with common
names (Grrr)
Maybe we can remove this stuff now?

[djsollen, 2016-05-23 18:13:06]

https://codereview.chromium.org/1999213002/diff/60001/tools/viewer/sk_app/uni...
File tools/viewer/sk_app/unix/Window_unix.h (right):

https://codereview.chromium.org/1999213002/diff/60001/tools/viewer/sk_app/uni...
tools/viewer/sk_app/unix/Window_unix.h:20: ::Window fHWnd;
so X11 calls their class Window as well? can you do a typedef of ::Window to
something like XWindow?

[jvanverth1, 2016-05-23 18:19:10]

I verified that nanobench still runs on Linux.

https://codereview.chromium.org/1999213002/diff/60001/include/gpu/vk/GrVkDefi...
File include/gpu/vk/GrVkDefines.h (left):

https://codereview.chromium.org/1999213002/diff/60001/include/gpu/vk/GrVkDefi...
include/gpu/vk/GrVkDefines.h:27: // Xlib.h may define these macros with common
names (Grrr)
On 2016/05/23 17:54:59, bsalomon wrote:
> Maybe we can remove this stuff now?

Done.

https://codereview.chromium.org/1999213002/diff/60001/tools/viewer/sk_app/uni...
File tools/viewer/sk_app/unix/Window_unix.h (right):

https://codereview.chromium.org/1999213002/diff/60001/tools/viewer/sk_app/uni...
tools/viewer/sk_app/unix/Window_unix.h:20: ::Window fHWnd;
On 2016/05/23 18:13:06, djsollen wrote:
> so X11 calls their class Window as well? can you do a typedef of ::Window to
> something like XWindow?

Done.

[bsalomon, 2016-05-23 19:19:42]

lgtm

[djsollen, 2016-05-23 19:25:03]

lgtm

[jvanverth1, 2016-05-23 19:59:26]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-05-23 19:59:27]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1999213002/#ps140001
(title: "Remove viewer hack")

[commit-bot: I haz the power, 2016-05-23 19:59:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999213002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999213002/140001

[commit-bot: I haz the power, 2016-05-23 20:13:41]

Description was changed from

==========
Add Xlib support to viewer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1999213002
==========

to

==========
Add Xlib support to viewer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1999213002

Committed:
https://skia.googlesource.com/skia/+/1d1559620058365e0de25636f1bcf07fcc071c3d
==========

[commit-bot: I haz the power, 2016-05-23 20:13:42]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/1d1559620058365e0de25636f1bcf07fcc071c3d