Add CanvasSurfaceLayerBridge

Add CanvasSurfaceLayerBridge

This is a preparatory patch for later works on adding a surface layer to canvas
when it is transferred control to an OffscreenCanvas. The SolidColorLayer is
just a stud here and will be replaced by SurfaceLayer later.

BUG=611796
Committed: https://crrev.com/9d411770ed1fe13a31f038859cba062e5d7bf952
Cr-Commit-Position: refs/heads/master@{#395741}

[xlai (Olivia), 2016-05-20 16:58:02]

xlai@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2016-05-20 19:58:26]

https://codereview.chromium.org/1999143002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
(right):

https://codereview.chromium.org/1999143002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp:126:
static inline bool isCanvasTransferedFromOffscreen(const LayoutObject*
layoutObject)
isCanvasControlledByOffscreen

https://codereview.chromium.org/1999143002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp:130:
if (!!canvas->surfaceLayerBridge())
"!!" is not necessary

https://codereview.chromium.org/1999143002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h
(right):

https://codereview.chromium.org/1999143002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h:25:
cc::SolidColorLayer* solidColorLayer() const { return m_solidColorLayer.get(); }
This method is not needed.

https://codereview.chromium.org/1999143002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h:26:
WebLayer* getWebLayer() const { return m_webLayer.get(); }
Just "webLayer".  In blink, we only put a verb prefix when there is some kind of
significant work involved in obtaning the return value.

[xlai (Olivia), 2016-05-20 20:26:32]

Edit based on comments.

[danakj, 2016-05-20 20:58:48]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-05-20 20:58:49]

https://codereview.chromium.org/1999143002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h
(right):

https://codereview.chromium.org/1999143002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h:26:
WebLayer* getWebLayer() const { return m_webLayer.get(); }
On 2016/05/20 19:58:26, Justin Novosad wrote:
> Just "webLayer".  In blink, we only put a verb prefix when there is some kind
of
> significant work involved in obtaning the return value.

Making it webLayer() means it will become WebLayer() when we rewrite to chromium
style which means in this class WebLayer() is ambiguous if you mean a WebLayer
constructor or this function. I would recommend keeping get on things that match
the type name.

[danakj, 2016-05-20 20:59:01]

Description was changed from

==========
Add CanvasSurfaceLayerBridge

This is a preparatory patch for later works on adding a surface layer to canvas
when it is transferred control to an OffscreenCanvas. The SolidColorLayer is
just a stud here and will be replaced by SurfaceLayer later.

BUG=611796
==========

to

==========
Add CanvasSurfaceLayerBridge

This is a preparatory patch for later works on adding a surface layer to canvas
when it is transferred control to an OffscreenCanvas. The SolidColorLayer is
just a stud here and will be replaced by SurfaceLayer later.

BUG=611796
==========

[danakj, 2016-05-20 20:59:01]

danakj@chromium.org changed reviewers:
- danakj@chromium.org

[xlai (Olivia), 2016-05-20 21:13:20]

xlai@chromium.org changed reviewers:
+ danakj@chromium.org

[xlai (Olivia), 2016-05-20 21:13:20]

Bring back getWebLayer().

[Justin Novosad, 2016-05-24 20:07:38]

as discussed, lgtm

[xlai (Olivia), 2016-05-24 20:09:43]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2016-05-24 20:10:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999143002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999143002/40001

[commit-bot: I haz the power, 2016-05-24 23:54:46]

Description was changed from

==========
Add CanvasSurfaceLayerBridge

This is a preparatory patch for later works on adding a surface layer to canvas
when it is transferred control to an OffscreenCanvas. The SolidColorLayer is
just a stud here and will be replaced by SurfaceLayer later.

BUG=611796
==========

to

==========
Add CanvasSurfaceLayerBridge

This is a preparatory patch for later works on adding a surface layer to canvas
when it is transferred control to an OffscreenCanvas. The SolidColorLayer is
just a stud here and will be replaced by SurfaceLayer later.

BUG=611796
==========

[commit-bot: I haz the power, 2016-05-24 23:54:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-24 23:56:15]

Description was changed from

==========
Add CanvasSurfaceLayerBridge

This is a preparatory patch for later works on adding a surface layer to canvas
when it is transferred control to an OffscreenCanvas. The SolidColorLayer is
just a stud here and will be replaced by SurfaceLayer later.

BUG=611796
==========

to

==========
Add CanvasSurfaceLayerBridge

This is a preparatory patch for later works on adding a surface layer to canvas
when it is transferred control to an OffscreenCanvas. The SolidColorLayer is
just a stud here and will be replaced by SurfaceLayer later.

BUG=611796

Committed: https://crrev.com/9d411770ed1fe13a31f038859cba062e5d7bf952
Cr-Commit-Position: refs/heads/master@{#395741}
==========

[commit-bot: I haz the power, 2016-05-24 23:56:18]

Patchset 3 (id:??) landed as
https://crrev.com/9d411770ed1fe13a31f038859cba062e5d7bf952
Cr-Commit-Position: refs/heads/master@{#395741}