Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1999143002: Add CanvasSurfaceLayerBridge (Closed)

Created:
4 years, 7 months ago by xlai (Olivia)
Modified:
4 years, 7 months ago
Reviewers:
danakj, Justin Novosad
CC:
chromium-reviews, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, kinuko+watch, rwlbuis, krit, drott+blinkwatch_chromium.org, szager+layoutwatch_chromium.org, dglazkov+blink, Rik, jchaffraix+rendering, blink-reviews, zoltan1, blink-reviews-layout_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, haraken, Stephen Chennney, ajuma+watch-canvas_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, f(malita), danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CanvasSurfaceLayerBridge This is a preparatory patch for later works on adding a surface layer to canvas when it is transferred control to an OffscreenCanvas. The SolidColorLayer is just a stud here and will be replaced by SurfaceLayer later. BUG=611796 Committed: https://crrev.com/9d411770ed1fe13a31f038859cba062e5d7bf952 Cr-Commit-Position: refs/heads/master@{#395741}

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : edit based on danakj's feedback #

Messages

Total messages: 17 (8 generated)
xlai (Olivia)
4 years, 7 months ago (2016-05-20 16:58:03 UTC) #2
Justin Novosad
https://codereview.chromium.org/1999143002/diff/1/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp File third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp (right): https://codereview.chromium.org/1999143002/diff/1/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp#newcode126 third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp:126: static inline bool isCanvasTransferedFromOffscreen(const LayoutObject* layoutObject) isCanvasControlledByOffscreen https://codereview.chromium.org/1999143002/diff/1/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp#newcode130 third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp:130: ...
4 years, 7 months ago (2016-05-20 19:58:26 UTC) #3
xlai (Olivia)
Edit based on comments.
4 years, 7 months ago (2016-05-20 20:26:32 UTC) #4
danakj
https://codereview.chromium.org/1999143002/diff/1/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h File third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h (right): https://codereview.chromium.org/1999143002/diff/1/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h#newcode26 third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h:26: WebLayer* getWebLayer() const { return m_webLayer.get(); } On 2016/05/20 ...
4 years, 7 months ago (2016-05-20 20:58:49 UTC) #6
xlai (Olivia)
Bring back getWebLayer().
4 years, 7 months ago (2016-05-20 21:13:20 UTC) #10
Justin Novosad
as discussed, lgtm
4 years, 7 months ago (2016-05-24 20:07:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999143002/40001
4 years, 7 months ago (2016-05-24 20:10:24 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-24 23:54:48 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 23:56:18 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9d411770ed1fe13a31f038859cba062e5d7bf952
Cr-Commit-Position: refs/heads/master@{#395741}

Powered by Google App Engine
This is Rietveld 408576698