Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1999103002: Stop creating CodecSrcs with unused scale (Closed)

Created:
4 years, 7 months ago by scroggo_chromium
Modified:
4 years, 7 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Stop creating CodecSrcs with unused scale Only JPEG and WEBP support native scaling, so only create a CodecSrc with a scale for those types. If I run dm --src image --images resources this cuts down the number of Srcs from 11063 to 8032. All of these trimmed Srcs would have failed quickly for each Sink (3 Sinks with the above flags), but this will avoid creating them. It drops the runtime on my mac from 13.2s to 11.4s, for about a 14% speedup. BUG=skia:5307 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1999103002 Committed: https://skia.googlesource.com/skia/+/9366aff1fa1ab8af1cddfc9a32b3aaa5ae2dd143

Patch Set 1 #

Patch Set 2 : Fix line length #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M dm/DM.cpp View 1 3 chunks +22 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
scroggo_chromium
4 years, 7 months ago (2016-05-20 14:08:32 UTC) #3
msarett
LGTM!
4 years, 7 months ago (2016-05-20 15:14:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999103002/20001
4 years, 7 months ago (2016-05-20 15:23:00 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 15:38:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9366aff1fa1ab8af1cddfc9a32b3aaa5ae2dd143

Powered by Google App Engine
This is Rietveld 408576698