Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1999083002: Finish eliminating PlatformWindowMus (Closed)

Created:
4 years, 7 months ago by Mark Dittmer
Modified:
4 years, 7 months ago
Reviewers:
nyquist, sadrul, sky
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, sadrul, sriramsr+watch-blimp_chromium.org, tfarina, maniscalco+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, kalyank, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Finish eliminating PlatformWindowMus R=sadrul@chromium.org BUG=609555 Committed: https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e Cr-Commit-Position: refs/heads/master@{#395694}

Patch Set 1 #

Patch Set 2 : Set upstream to 1988283002 #

Patch Set 3 : rebase #

Patch Set 4 : Bring back if (connector) { ... } dropped in copy over from PlatformWindowMus #

Patch Set 5 : Add comment regarding no-connector case in WindowTreeHostMus #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -275 lines) Patch
M ash/host/ash_window_tree_host_unified.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/mus/sysui_application.cc View 1 chunk +2 lines, -1 line 0 comments Download
M blimp/engine/app/ui/blimp_window_tree_host.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/platform_window/stub/stub_window.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/platform_window/stub/stub_window.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 2 3 4 5 6 chunks +16 lines, -16 lines 0 comments Download
M ui/views/mus/native_widget_mus_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -52 lines 0 comments Download
D ui/views/mus/platform_window_mus.h View 1 chunk +0 lines, -80 lines 0 comments Download
D ui/views/mus/platform_window_mus.cc View 1 2 1 chunk +0 lines, -109 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.h View 4 chunks +12 lines, -2 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.cc View 1 2 3 4 3 chunks +36 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (4 generated)
Mark Dittmer
4 years, 7 months ago (2016-05-20 13:35:51 UTC) #1
Mark Dittmer
nyquist@chromium.org: Please review changes in blimp sky@chromium.org: Please review changes in ash Both are equivalent ...
4 years, 7 months ago (2016-05-20 13:38:07 UTC) #3
Mark Dittmer
Set upstream to 1988283002
4 years, 7 months ago (2016-05-20 13:40:09 UTC) #4
Mark Dittmer
rebase
4 years, 7 months ago (2016-05-20 14:33:05 UTC) #5
sky
ash LGTM
4 years, 7 months ago (2016-05-20 16:28:47 UTC) #6
Mark Dittmer
Bring back if (connector) { ... } dropped in copy over from PlatformWindowMus
4 years, 7 months ago (2016-05-20 17:31:15 UTC) #7
Mark Dittmer
Add comment regarding no-connector case in WindowTreeHostMus
4 years, 7 months ago (2016-05-20 18:11:50 UTC) #8
nyquist
blimp lgtm
4 years, 7 months ago (2016-05-23 21:10:26 UTC) #9
sadrul
lgtm
4 years, 7 months ago (2016-05-24 16:06:53 UTC) #10
Mark Dittmer
rebase
4 years, 7 months ago (2016-05-24 17:35:18 UTC) #11
Mark Dittmer
rebase
4 years, 7 months ago (2016-05-24 19:06:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999083002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999083002/120001
4 years, 7 months ago (2016-05-24 19:06:55 UTC) #15
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 7 months ago (2016-05-24 21:13:06 UTC) #16
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e Cr-Commit-Position: refs/heads/master@{#395694}
4 years, 7 months ago (2016-05-24 21:15:58 UTC) #18
sadrul
4 years, 7 months ago (2016-05-25 02:12:05 UTC) #19
Message was sent while issue was closed. 
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2013713002/ by sadrul@chromium.org.

The reason for reverting is: This breaks window-frames in mash.

Powered by Google App Engine
This is Rietveld 408576698