Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1999073002: Revert of [BattOr][Telemetry] Changes needed to run BattOr tests on telemetry. (Closed)

Created:
4 years, 7 months ago by Sami
Modified:
4 years, 7 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [BattOr][Telemetry] Changes needed to run BattOr tests on telemetry. (patchset #5 id:100001 of https://codereview.chromium.org/1980773002/ ) Reason for revert: Reverting since this is causing redness on the waterfall (tested with a local revert): https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%283%29/builds/16426/steps/tracing.tracing_with_debug_overhead/logs/stdio Note that https://codereview.chromium.org/1998673003/ also needed to be reverted. Original issue's description: > [BattOr][Telemetry] Changes needed to run BattOr tests on telemetry. > > Small changes required to push battor data through to telemetry results and disable charging. > > BUG=catapult:#2309 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/20d5ca9cc4f3c1612f8a0e29e4d5cfa6f146cbfc TBR=nednguyen@google.com,charliea@chromium.org,rnephew@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#2309 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c5946d3f3c6f9f04ed893e508f01289502a598c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -113 lines) Patch
M telemetry/telemetry/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent.py View 4 chunks +1 line, -21 lines 0 comments Download
M telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py View 3 chunks +1 line, -24 lines 0 comments Download
M telemetry/telemetry/timeline/trace_data.py View 2 chunks +4 lines, -8 lines 0 comments Download
M telemetry/telemetry/timeline/trace_data_unittest.py View 4 chunks +3 lines, -15 lines 0 comments Download
M telemetry/telemetry/value/trace.py View 1 chunk +4 lines, -8 lines 0 comments Download
M telemetry/telemetry/value/trace_unittest.py View 2 chunks +0 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sami
Created Revert of [BattOr][Telemetry] Changes needed to run BattOr tests on telemetry.
4 years, 7 months ago (2016-05-20 13:03:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999073002/1
4 years, 7 months ago (2016-05-20 13:03:36 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 13:03:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698