Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 199903002: Introduce Push and Pop macro instructions for x64 (Closed)

Created:
6 years, 9 months ago by haitao.feng
Modified:
6 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Introduce Push and Pop macro instructions for x64 R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20049

Patch Set 1 #

Patch Set 2 : Addressed comment #

Patch Set 3 : Rebased with bleeding_edge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+729 lines, -644 lines) Patch
M src/x64/assembler-x64.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 32 chunks +55 lines, -55 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 2 chunks +10 lines, -10 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 33 chunks +89 lines, -89 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 5 chunks +10 lines, -10 lines 0 comments Download
M src/x64/debug-x64.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 2 8 chunks +13 lines, -13 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 83 chunks +132 lines, -132 lines 0 comments Download
M src/x64/ic-x64.cc View 1 11 chunks +28 lines, -28 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 28 chunks +36 lines, -36 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 2 chunks +10 lines, -6 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 27 chunks +155 lines, -76 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 11 chunks +32 lines, -32 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 14 chunks +38 lines, -36 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 8 chunks +36 lines, -36 lines 0 comments Download
M test/cctest/test-code-stubs-x64.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M test/cctest/test-hashing.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 8 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haitao.feng
Toon, please take a took. 64-bit CPU does not have native instructions to do 32-bit ...
6 years, 9 months ago (2014-03-14 04:04:18 UTC) #1
Toon Verwaest
Seems like these instructions should be introduced at the macro-assembler level rather than assembler. Can ...
6 years, 9 months ago (2014-03-17 15:16:19 UTC) #2
haitao.feng
Done. I extended the existing Push/Pop macro instruction as we already have them to abstract ...
6 years, 9 months ago (2014-03-18 14:51:44 UTC) #3
Toon Verwaest
Nice. LGTM
6 years, 9 months ago (2014-03-18 14:57:38 UTC) #4
haitao.feng
6 years, 9 months ago (2014-03-19 08:59:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r20049 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698