Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1998993003: Add a test for the "Sign in" button in the account chooser on Views. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
Reviewers:
vabr (Chromium), dvadym
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for the "Sign in" button in the account chooser on Views. BUG=612501 Committed: https://crrev.com/09230ce8c499ed846ac7f0a1b5ca169cb18cbcec Cr-Commit-Position: refs/heads/master@{#395326}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc View 1 3 chunks +56 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
vasilii
Hi Vadym, please review.
4 years, 7 months ago (2016-05-20 14:01:11 UTC) #2
vasilii
Hi Vaclav, please review.
4 years, 7 months ago (2016-05-23 13:58:52 UTC) #4
vabr (Chromium)
lgtm https://codereview.chromium.org/1998993003/diff/1/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc File chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc (right): https://codereview.chromium.org/1998993003/diff/1/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc#newcode50 chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc:50: bool widget_closed() const { return widget_ == NULL; ...
4 years, 7 months ago (2016-05-23 14:09:14 UTC) #5
vasilii
https://codereview.chromium.org/1998993003/diff/1/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc File chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc (right): https://codereview.chromium.org/1998993003/diff/1/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc#newcode50 chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc:50: bool widget_closed() const { return widget_ == NULL; } ...
4 years, 7 months ago (2016-05-23 14:15:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998993003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998993003/20001
4 years, 7 months ago (2016-05-23 14:16:04 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-23 15:09:25 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 15:10:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09230ce8c499ed846ac7f0a1b5ca169cb18cbcec
Cr-Commit-Position: refs/heads/master@{#395326}

Powered by Google App Engine
This is Rietveld 408576698