Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Unified Diff: runtime/bin/builtin_common.cc

Issue 1998963003: Rework standalone to use a synchronous loader that does not invoke Dart code (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/builtin_common.cc
diff --git a/runtime/bin/builtin_common.cc b/runtime/bin/builtin_common.cc
index 678e48b7163fac199fded9d936144649417ac2a6..bbf9788506ae6bdd5c6ae201ac1c891f576f9faf 100644
--- a/runtime/bin/builtin_common.cc
+++ b/runtime/bin/builtin_common.cc
@@ -40,6 +40,11 @@ Dart_Handle Builtin::SetLoadPort(Dart_Port port) {
RETURN_IF_ERROR(send_port);
Dart_Handle result = Dart_SetField(builtin_lib, field_name, send_port);
RETURN_IF_ERROR(result);
+ // Also set the _isolateId field.
+ result = Dart_SetField(builtin_lib,
+ DartUtils::NewString("_isolateId"),
+ Dart_NewInteger(Dart_GetMainPortId()));
+ RETURN_IF_ERROR(result);
turnidge 2016/06/03 17:50:24 Would be nice if the function failed on a second c
Cutch 2016/06/03 22:07:32 Done.
return Dart_True();
}

Powered by Google App Engine
This is Rietveld 408576698