Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1998963002: Input: TouchEventManager and PointerEventManager are non-copyable (Closed)

Created:
4 years, 7 months ago by Eric Willigers
Modified:
4 years, 7 months ago
Reviewers:
keishi
CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Input: TouchEventManager and PointerEventManager are non-copyable Declare TouchEventManager and PointerEventManager as non-copyable. BUG=613450 R=keishi@chromium.org Committed: https://crrev.com/ab4338e9e30c29c0bf95f47bc90f7d044c7e708d Cr-Commit-Position: refs/heads/master@{#395060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/input/PointerEventManager.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Eric Willigers
4 years, 7 months ago (2016-05-20 06:22:25 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998963002/1
4 years, 7 months ago (2016-05-20 06:37:53 UTC) #3
keishi
LGTM
4 years, 7 months ago (2016-05-20 06:53:10 UTC) #4
Eric Willigers
4 years, 7 months ago (2016-05-20 07:30:09 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/225626)
4 years, 7 months ago (2016-05-20 11:43:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998963002/1
4 years, 7 months ago (2016-05-20 12:05:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 12:57:39 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 12:58:42 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ab4338e9e30c29c0bf95f47bc90f7d044c7e708d
Cr-Commit-Position: refs/heads/master@{#395060}

Powered by Google App Engine
This is Rietveld 408576698