Chromium Code Reviews
Description[Telemetry] Cast results to unicode utf-8 before write it to html_output_format's output stream
This fixes the bug found in https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/217229/steps/telemetry_perf_unittests%20%28with%20patch%29%20on%20Windows-7-SP1/logs/stdio
Traceback (most recent call last):
File "e:\b\swarm_slave\work\isolated\runq5_gvs\tools\perf\benchmarks\benchmark_smoke_unittest.py", line 73, in BenchmarkSmokeTest
self.assertEqual(0, SinglePageBenchmark().Run(options),
File "e:\b\swarm_slave\work\isolated\runq5_gvs\third_party\catapult\telemetry\telemetry\benchmark.py", line 91, in Run
return story_runner.RunBenchmark(self, finder_options)
File "e:\b\swarm_slave\work\isolated\runq5_gvs\third_party\catapult\telemetry\telemetry\internal\story_runner.py", line 324, in RunBenchmark
results.PrintSummary()
File "e:\b\swarm_slave\work\isolated\runq5_gvs\third_party\catapult\telemetry\telemetry\internal\results\page_test_results.py", line 240, in PrintSummary
output_formatter.Format(self)
File "e:\b\swarm_slave\work\isolated\runq5_gvs\third_party\catapult\telemetry\telemetry\internal\results\html_output_formatter.py", line 173, in Format
self._SaveResults(html)
File "e:\b\swarm_slave\work\isolated\runq5_gvs\third_party\catapult\telemetry\telemetry\internal\results\html_output_formatter.py", line 93, in _SaveResults
self._output_stream.write(results)
File "e:\b\depot_tools\python276_bin\lib\codecs.py", line 691, in write
return self.writer.write(data)
File "e:\b\depot_tools\python276_bin\lib\codecs.py", line 351, in write
data, consumed = self.encode(object, self.errors)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 55035: ordinal not in range(128)
TBR=benjhayden@chromium.org,eakuefner@chromium.org
BUG=chromium:613421
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1279400675a35a620639be80ec667a3c1a436821
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
||||||||||||||||||||||||||||