Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1998943002: [Telemetry] Cast results to unicode utf-8 before write it to html_output_format's output stream (Closed)

Created:
4 years, 7 months ago by nednguyen
Modified:
4 years, 7 months ago
Reviewers:
eakuefner, benjhayden
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Cast results to unicode utf-8 before write it to html_output_format's output stream This fixes the bug found in https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/217229/steps/telemetry_perf_unittests%20%28with%20patch%29%20on%20Windows-7-SP1/logs/stdio Traceback (most recent call last): File "e:\b\swarm_slave\work\isolated\runq5_gvs\tools\perf\benchmarks\benchmark_smoke_unittest.py", line 73, in BenchmarkSmokeTest self.assertEqual(0, SinglePageBenchmark().Run(options), File "e:\b\swarm_slave\work\isolated\runq5_gvs\third_party\catapult\telemetry\telemetry\benchmark.py", line 91, in Run return story_runner.RunBenchmark(self, finder_options) File "e:\b\swarm_slave\work\isolated\runq5_gvs\third_party\catapult\telemetry\telemetry\internal\story_runner.py", line 324, in RunBenchmark results.PrintSummary() File "e:\b\swarm_slave\work\isolated\runq5_gvs\third_party\catapult\telemetry\telemetry\internal\results\page_test_results.py", line 240, in PrintSummary output_formatter.Format(self) File "e:\b\swarm_slave\work\isolated\runq5_gvs\third_party\catapult\telemetry\telemetry\internal\results\html_output_formatter.py", line 173, in Format self._SaveResults(html) File "e:\b\swarm_slave\work\isolated\runq5_gvs\third_party\catapult\telemetry\telemetry\internal\results\html_output_formatter.py", line 93, in _SaveResults self._output_stream.write(results) File "e:\b\depot_tools\python276_bin\lib\codecs.py", line 691, in write return self.writer.write(data) File "e:\b\depot_tools\python276_bin\lib\codecs.py", line 351, in write data, consumed = self.encode(object, self.errors) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 55035: ordinal not in range(128) TBR=benjhayden@chromium.org,eakuefner@chromium.org BUG=chromium:613421 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1279400675a35a620639be80ec667a3c1a436821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M telemetry/telemetry/internal/results/html_output_formatter.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/results/results_options.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998943002/1
4 years, 7 months ago (2016-05-20 05:25:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1279400675a35a620639be80ec667a3c1a436821
4 years, 7 months ago (2016-05-20 05:49:16 UTC) #5
benjhayden
4 years, 7 months ago (2016-05-20 15:48:54 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698