ash/system/toast/toast_manager_unittest.cc - Issue 1998933002: Update shelf spacing in Chrome OS according to the MD specs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/toast/toast_manager_unittest.cc

Issue 1998933002: Update shelf spacing in Chrome OS according to the MD specs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments & Refactor border around item implementation Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/system/toast/toast_manager_unittest.cc

diff --git a/ash/system/toast/toast_manager_unittest.cc b/ash/system/toast/toast_manager_unittest.cc

index 3f2b097389b97574c60d058d2c4baf6dcb0df4b1..e416cdfefa9d1cf4a6e41e1caad858500fd60894 100644

--- a/ash/system/toast/toast_manager_unittest.cc

+++ b/ash/system/toast/toast_manager_unittest.cc

@@ -5,6 +5,7 @@

#include "ash/display/display_manager.h"

#include "ash/screen_util.h"

#include "ash/shelf/shelf.h"

+#include "ash/shelf/shelf_constants.h"

#include "ash/shelf/shelf_layout_manager.h"

#include "ash/shell.h"

#include "ash/system/toast/toast_manager.h"

@@ -197,8 +198,7 @@ TEST_F(ToastManagerTest, PositionWithAutoHiddenBottomShelf) {

EXPECT_TRUE(toast_bounds.Intersects(shelf->user_work_area_bounds()));

EXPECT_NEAR(root_bounds.CenterPoint().x(), toast_bounds.CenterPoint().x(), 1);

- EXPECT_EQ(root_bounds.bottom() - ShelfLayoutManager::kAutoHideSize - 5,

- toast_bounds.bottom());

+ EXPECT_EQ(root_bounds.bottom() - kAutoHideSize - 5, toast_bounds.bottom());

}

TEST_F(ToastManagerTest, PositionWithHiddenBottomShelf) {

« ash/system/status_area_widget_delegate.cc ('K') | « ash/system/status_area_widget_delegate.cc ('k') | ash/system/tray/system_tray.h » ('j') | ash/system/tray/tray_background_view.h » ('J')