ash/shelf/overflow_bubble_view.cc - Issue 1998933002: Update shelf spacing in Chrome OS according to the MD specs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/overflow_bubble_view.cc

Issue 1998933002: Update shelf spacing in Chrome OS according to the MD specs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments & Refactor border around item implementation Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shelf/overflow_bubble_view.cc

diff --git a/ash/shelf/overflow_bubble_view.cc b/ash/shelf/overflow_bubble_view.cc

index f797fb6e926d3bca9ef10a3149c0e254d6cc9156..58f6e03e5041fa2e37661f8a38262e4206a96f1e 100644

--- a/ash/shelf/overflow_bubble_view.cc

+++ b/ash/shelf/overflow_bubble_view.cc

@@ -176,7 +176,7 @@ gfx::Rect OverflowBubbleView::GetBubbleBounds() {

views::BubbleBorder::is_arrow_on_horizontal(arrow()) ?

bubble_insets.left() : bubble_insets.top();

const int arrow_offset = border_size + kPadding + kShelfViewLeadingInset +

- kShelfSize / 2;

+ GetShelfLayoutConstant(SHELF_SIZE) / 2;

const gfx::Size content_size = GetPreferredSize();

border->set_arrow_offset(arrow_offset);

« ash/shelf/app_list_button.cc ('K') | « ash/shelf/app_list_button.cc ('k') | ash/shelf/overflow_button.cc » ('j') | ash/shelf/overflow_button.cc » ('J')