chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc - Issue 1998933002: Update shelf spacing in Chrome OS according to the MD specs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

Issue 1998933002: Update shelf spacing in Chrome OS according to the MD specs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address @jamescook comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/apps/chrome_app_delegate.cc ('k') | chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc » ('j') | chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

index abd23f7c33532c2e46cfb422f1aecef4290e3169..81995069ba49462f14a5be9c0f08d5940f78c59b 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

@@ -854,7 +854,7 @@ IN_PROC_BROWSER_TEST_F(LauncherPlatformAppBrowserTest, SetIcon) {

EXPECT_TRUE(app_item_controller->image_set_by_controller());

EXPECT_TRUE(panel_item_controller->image_set_by_controller());

// Ensure icon heights are correct (see test.js in app_icon/ test directory)

- EXPECT_EQ(ash::kShelfSize, app_item.image.height());

+ EXPECT_EQ(ash::GetShelfConstant(ash::SHELF_SIZE), app_item.image.height());

EXPECT_EQ(64, panel_item.image.height());

}