chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc - Issue 1998933002: Update shelf spacing in Chrome OS according to the MD specs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

Issue 1998933002: Update shelf spacing in Chrome OS according to the MD specs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc ('K') | « chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc ('k') | chrome/test/base/view_event_test_platform_part_chromeos.cc » ('j') | chrome/test/base/view_event_test_platform_part_chromeos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

diff --git a/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc b/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

index af75db3dfc3f3b5ce3754008fda79e059c10a299..2606e66d58e0aef729a1fc0f39a087a01c956268 100644

--- a/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

+++ b/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

@@ -158,8 +158,8 @@ IN_PROC_BROWSER_TEST_F(LauncherFaviconLoaderBrowsertest, ManyLauncherIcons) {

EXPECT_FALSE(favicon_loader_->GetFavicon().empty());

// When multiple favicons are present, the correctly sized icon should be

- // chosen. The icons are sized assuming ash::kShelfSize < 128.

- EXPECT_GT(128, ash::kShelfSize);

+ // chosen. The icons are sized assuming ash::SHELF_SIZE < 128.

+ EXPECT_GT(128, ash::GetShelfConstant(ash::SHELF_SIZE));

EXPECT_EQ(48, favicon_loader_->GetFavicon().height());

}