ash/system/toast/toast_manager_unittest.cc - Issue 1998933002: Update shelf spacing in Chrome OS according to the MD specs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/toast/toast_manager_unittest.cc

Issue 1998933002: Update shelf spacing in Chrome OS according to the MD specs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/system/status_area_widget_delegate.cc ('K') | « ash/system/status_area_widget_delegate.cc ('k') | ash/system/tray/tray_background_view.cc » ('j') | chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/system/toast/toast_manager_unittest.cc

diff --git a/ash/system/toast/toast_manager_unittest.cc b/ash/system/toast/toast_manager_unittest.cc

index e6d7556d57314360c38ac1fb8988f72d1e2a3315..3e9c498b8014227af1d7c1c96684a2b84553c1f6 100644

--- a/ash/system/toast/toast_manager_unittest.cc

+++ b/ash/system/toast/toast_manager_unittest.cc

@@ -2,6 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "ash/common/shelf/shelf_constants.h"

#include "ash/display/display_manager.h"

#include "ash/screen_util.h"

#include "ash/shelf/shelf.h"

@@ -196,7 +197,7 @@ TEST_F(ToastManagerTest, PositionWithAutoHiddenBottomShelf) {

EXPECT_TRUE(toast_bounds.Intersects(shelf->user_work_area_bounds()));

EXPECT_NEAR(root_bounds.CenterPoint().x(), toast_bounds.CenterPoint().x(), 1);

- EXPECT_EQ(root_bounds.bottom() - ShelfLayoutManager::kAutoHideSize - 5,

+ EXPECT_EQ(root_bounds.bottom() - kShelfAutoHideSize - 5,

toast_bounds.bottom());

}