Update shelf spacing in Chrome OS according to the MD specs

ash/system/status_area_widget_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SYSTEM_STATUS_AREA_WIDGET_DELEGATE_H_
 #define ASH_SYSTEM_STATUS_AREA_WIDGET_DELEGATE_H_
 
 #include "ash/ash_export.h"
 #include "ash/common/shelf/shelf_types.h"
 #include "ash/wm/gestures/shelf_gesture_handler.h"
 #include "base/macros.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/views/accessible_pane_view.h"
 #include "ui/views/widget/widget_delegate.h"
 
 namespace ash {

[tdanderson, 2016/06/10 22:54:43]

you don't need/want both line 16 and line 20

[yiyix, 2016/06/13 18:43:55]

Done.

+class TrayBackgroundView;
+}
+
+namespace ash {
 class FocusCycler;
 
 class ASH_EXPORT StatusAreaWidgetDelegate : public views::AccessiblePaneView,
                                             public views::WidgetDelegate {
  public:
   StatusAreaWidgetDelegate();
   ~StatusAreaWidgetDelegate() override;
 
   // Add a tray view to the widget (e.g. system tray, web notifications).
-  void AddTray(views::View* tray);
+  void AddTray(TrayBackgroundView* tray);

[tdanderson, 2016/06/10 22:54:43]

I was looking over the chat you, me, and Ben had last week (in the CL comments)
and he suggested using a static_cast<TrayBackgroundView> in
StatusAreaWidgetDelegate::UpdateLayout(). You haven't done that, but I think I
actually prefer what you've done instead (move the border-setting code out of
TrayBackgroundView and into StatusAreaWidgetDelegate).

So with that said, since you're not doing the static cast, there's really no
reason to change this type anymore. I'd just keep it as a View*. (Also you can
remove the class declaration on line 17)

[yiyix, 2016/06/13 18:43:55]

I did not really like the casting. I am glad that you prefer this way as well.

 
   // Called whenever layout might change (e.g. alignment changed).
   void UpdateLayout();
 
   // Sets the focus cycler.
   void SetFocusCyclerForTesting(const FocusCycler* focus_cycler);
 
   void set_alignment(ShelfAlignment alignment) { alignment_ = alignment; }
 
   // Overridden from views::AccessiblePaneView.
@@ skipping 11 matching lines @@
   void DeleteDelegate() override;
 
  protected:
   // Overridden from views::View:
   void ChildPreferredSizeChanged(views::View* child) override;
   void ChildVisibilityChanged(views::View* child) override;
 
  private:
   void UpdateWidgetSize();
 
+  // Tray shows on the right most edge requires an extra wide inset, so edge is

[tdanderson, 2016/06/10 22:54:43]

nit on wording, change to something like: "Sets a border on |child|. If
|extend_border_to_edge| is true, then an extra wide border is added to extend
the view's hit region to the edge of the screen."

[yiyix, 2016/06/13 18:43:55]

Done.

+  // included the hitting area .
+  void SetBorderOnEdgeTray(views::View* child);
+  void SetBorderOnNonEdgeTray(views::View* child);

[tdanderson, 2016/06/10 22:54:43]

Combine into a single function, such as:

void SetBorderOnChild(View* child, bool extend_border_to_edge)

[yiyix, 2016/06/13 18:43:55]

Done.

+
   const FocusCycler* focus_cycler_for_testing_;
   ShelfAlignment alignment_;
 
   ShelfGestureHandler gesture_handler_;
 
   DISALLOW_COPY_AND_ASSIGN(StatusAreaWidgetDelegate);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SYSTEM_STATUS_AREA_WIDGET_DELEGATE_H_