Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 199893006: Remove bogus if check in ShadowTreeStyleSheetCollection::collectStyleSheets() (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
Hajime Morrita, esprehn
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, tasak (please_use_google.com)
Visibility:
Public.

Description

Remove bogus if check in ShadowTreeStyleSheetCollection::collectStyleSheets() Remove bogus if check in ShadowTreeStyleSheetCollection::collectStyleSheets(). The condition will always be true as HTMLStyleElement always has a styleTag for tag name. R=esprehn, morrita@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169713

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M Source/core/dom/ShadowTreeStyleSheetCollection.cpp View 1 chunk +3 lines, -5 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Inactive
I am not sure what the original intent was so I am adding tasak@ in ...
6 years, 9 months ago (2014-03-17 19:31:27 UTC) #1
Inactive
On 2014/03/17 19:31:27, Chris Dumez wrote: > I am not sure what the original intent ...
6 years, 9 months ago (2014-03-20 14:14:19 UTC) #2
Hajime Morrita
lgtm. Oops. I'm sorry for overlooking this.
6 years, 9 months ago (2014-03-21 01:18:33 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-21 01:20:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/199893006/1
6 years, 9 months ago (2014-03-21 01:20:33 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 01:30:10 UTC) #6
Message was sent while issue was closed.
Change committed as 169713

Powered by Google App Engine
This is Rietveld 408576698