Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 199893005: Deprecate ChangeLog on bleeding_edge. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach
Modified:
6 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Jarin
Visibility:
Public.

Description

Deprecate ChangeLog on bleeding_edge. - This adds a sentinel to the ChangeLog on bleeding edge. - Modifying the ChangeLog file directly when pushing to trunk is now no longer possible. If further modifications to the ChangeLog in manual push-to-trunk mode are required (e.g. after the prepare push LGTM), the change log entry temp file must be edited. - Functionality that is no longer needed is removed. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -54 lines) Patch
M ChangeLog View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/push-to-trunk/common_includes.py View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 6 chunks +3 lines, -15 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 5 chunks +5 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 9 months ago (2014-03-17 14:29:08 UTC) #1
Jakob Kummerow
lgtm
6 years, 9 months ago (2014-03-18 12:19:32 UTC) #2
Michael Achenbach
6 years, 9 months ago (2014-03-18 12:46:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20029 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698