Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1998903002: Revert of Added the --screenshot option. (Closed)

Created:
4 years, 7 months ago by jbudorick
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added the --screenshot option. (patchset #7 id:120001 of https://codereview.chromium.org/1981043004/ ) Reason for revert: breaks downstream Original issue's description: > Added the --screenshot option. > > --screenshot option was broken for instrumentation tests. In this cl, > the option is enabled. With argument --screenshot, the device will take > a screenshot whenever an instrumentation test fails. > > BUG=611538 > > Committed: https://crrev.com/09891bc02742f34a11a6d8ffd8993066f6c1b62c > Cr-Commit-Position: refs/heads/master@{#394843} TBR=mikecase@chromium.org,hzl@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=611538 Committed: https://crrev.com/5a6fa1e0d268e6ef3f15aff3bb63fae8b94396cd Cr-Commit-Position: refs/heads/master@{#394956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 2 chunks +0 lines, -5 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 2 chunks +0 lines, -10 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jbudorick
Created Revert of Added the --screenshot option.
4 years, 7 months ago (2016-05-20 01:39:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998903002/1
4 years, 7 months ago (2016-05-20 01:40:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 01:40:52 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 01:43:50 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a6fa1e0d268e6ef3f15aff3bb63fae8b94396cd
Cr-Commit-Position: refs/heads/master@{#394956}

Powered by Google App Engine
This is Rietveld 408576698