xfa/fxfa/parser/xfa_object_imp.cpp - Issue 1998873002: Clean up XFA code which causes warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_object_imp.cpp

Issue 1998873002: Clean up XFA code which causes warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_object_imp.cpp

diff --git a/xfa/fxfa/parser/xfa_object_imp.cpp b/xfa/fxfa/parser/xfa_object_imp.cpp

index 0fbde1f160533dec3e74d7bcbe1ce29ef15efe9b..6a6303e64e2c3afe834e0e752edd3d0efc2074bb 100644

--- a/xfa/fxfa/parser/xfa_object_imp.cpp

+++ b/xfa/fxfa/parser/xfa_object_imp.cpp

@@ -4504,7 +4504,7 @@ CXFA_Node* CXFA_Node::GetProperty(int32_t index,

}

CXFA_Document* pFactory = m_pDocument->GetParser()->GetFactory();

const XFA_PACKETINFO* pPacket = XFA_GetPacketByID(dwPacket);

- CXFA_Node* pNewNode;

+ CXFA_Node* pNewNode = nullptr;

for (; iCount <= index; iCount++) {

pNewNode = pFactory->CreateNode(pPacket, eProperty);

if (!pNewNode) {

« no previous file with comments | « xfa/fxfa/parser/xfa_localemgr.cpp ('k') | xfa/fxfa/parser/xfa_parser_imp.cpp » ('j') | no next file with comments »