xfa/fxfa/app/xfa_ffwidgetacc.cpp - Issue 1998873002: Clean up XFA code which causes warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_ffwidgetacc.cpp

Issue 1998873002: Clean up XFA code which causes warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/app/xfa_ffwidgetacc.cpp

diff --git a/xfa/fxfa/app/xfa_ffwidgetacc.cpp b/xfa/fxfa/app/xfa_ffwidgetacc.cpp

index 08c52de79aa4ffc166381a65302ab1136884c06c..2c84a7f9b7489cda85cdfcf9046d8167158f725f 100644

--- a/xfa/fxfa/app/xfa_ffwidgetacc.cpp

+++ b/xfa/fxfa/app/xfa_ffwidgetacc.cpp

@@ -713,7 +713,7 @@ CXFA_FFWidget* CXFA_WidgetAcc::GetNextWidget(CXFA_FFWidget* pWidget) {

}

void CXFA_WidgetAcc::UpdateUIDisplay(CXFA_FFWidget* pExcept) {

CXFA_FFWidget* pWidget = NULL;

- while ((pWidget = GetNextWidget(pWidget))) {

+ while ((pWidget = GetNextWidget(pWidget)) != nullptr) {

if (pWidget == pExcept || !pWidget->IsLoaded() ||

(GetUIType() != XFA_ELEMENT_CheckButton && pWidget->IsFocused())) {

continue;

« no previous file with comments | « xfa/fxfa/app/xfa_ffwidget.cpp ('k') | xfa/fxfa/fm2js/xfa_fm2jscontext.cpp » ('j') | no next file with comments »