Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2822)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp

Issue 1998873002: Clean up XFA code which causes warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« xfa/fwl/core/fwl_widgetmgrimp.cpp ('K') | « xfa/fxbarcode/oned/BC_OnedCode128Reader.cpp ('k') | xfa/fxbarcode/oned/BC_OnedUPCAReader.cpp » ('j') | xfa/fxfa/app/xfa_ffwidget.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp
diff --git a/xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp b/xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp
index 5806b3d09da3274b1ab367f3a21252827701c038..bc9b14f04e2e989da67c3e384d615be25522f814 100644
--- a/xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp
+++ b/xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp
@@ -45,10 +45,7 @@ FX_BOOL CBC_OnedCode128Writer::CheckContentValidity(
if (m_codeFormat == BC_CODE128_B || m_codeFormat == BC_CODE128_C) {
while (position < contents.GetLength()) {
patternIndex = (int32_t)contents.GetAt(position);
- if (patternIndex >= 32 && patternIndex <= 126 && patternIndex != 34) {
- position++;
- continue;
- } else {
+ if (patternIndex < 32 || patternIndex > 126 || patternIndex == 34) {
ret = FALSE;
break;
}
« xfa/fwl/core/fwl_widgetmgrimp.cpp ('K') | « xfa/fxbarcode/oned/BC_OnedCode128Reader.cpp ('k') | xfa/fxbarcode/oned/BC_OnedUPCAReader.cpp » ('j') | xfa/fxfa/app/xfa_ffwidget.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698