Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Side by Side Diff: xfa/fxfa/parser/xfa_utils_imp.cpp

Issue 1998873002: Clean up XFA code which causes warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fxfa/parser/xfa_utils.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fxfa/parser/xfa_utils.h" 7 #include "xfa/fxfa/parser/xfa_utils.h"
8 8
9 #include "core/fxcrt/include/fx_ext.h" 9 #include "core/fxcrt/include/fx_ext.h"
10 #include "xfa/fde/xml/fde_xml_imp.h" 10 #include "xfa/fde/xml/fde_xml_imp.h"
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 FX_BOOL XFA_IsLayoutElement(XFA_ELEMENT eElement, FX_BOOL bLayoutContainer) { 248 FX_BOOL XFA_IsLayoutElement(XFA_ELEMENT eElement, FX_BOOL bLayoutContainer) {
249 switch (eElement) { 249 switch (eElement) {
250 case XFA_ELEMENT_Draw: 250 case XFA_ELEMENT_Draw:
251 case XFA_ELEMENT_Field: 251 case XFA_ELEMENT_Field:
252 case XFA_ELEMENT_InstanceManager: 252 case XFA_ELEMENT_InstanceManager:
253 return !bLayoutContainer; 253 return !bLayoutContainer;
254 case XFA_ELEMENT_Area: 254 case XFA_ELEMENT_Area:
255 case XFA_ELEMENT_Subform: 255 case XFA_ELEMENT_Subform:
256 case XFA_ELEMENT_ExclGroup: 256 case XFA_ELEMENT_ExclGroup:
257 case XFA_ELEMENT_SubformSet: 257 case XFA_ELEMENT_SubformSet:
258 return TRUE;
259 case XFA_ELEMENT_PageArea: 258 case XFA_ELEMENT_PageArea:
260 case XFA_ELEMENT_Form: 259 case XFA_ELEMENT_Form:
261 return TRUE; 260 return TRUE;
262 default: 261 default:
263 return FALSE; 262 return FALSE;
264 } 263 }
265 return FALSE;
266 } 264 }
267 265
268 static const FX_DOUBLE fraction_scales[] = {0.1, 266 static const FX_DOUBLE fraction_scales[] = {0.1,
269 0.01, 267 0.01,
270 0.001, 268 0.001,
271 0.0001, 269 0.0001,
272 0.00001, 270 0.00001,
273 0.000001, 271 0.000001,
274 0.0000001, 272 0.0000001,
275 0.00000001, 273 0.00000001,
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 FX_DOUBLE XFA_ByteStringToDouble(const CFX_ByteStringC& szStringVal) { 361 FX_DOUBLE XFA_ByteStringToDouble(const CFX_ByteStringC& szStringVal) {
364 CFX_WideString wsValue = CFX_WideString::FromUTF8(szStringVal); 362 CFX_WideString wsValue = CFX_WideString::FromUTF8(szStringVal);
365 return XFA_WideStringToDouble(wsValue); 363 return XFA_WideStringToDouble(wsValue);
366 } 364 }
367 365
368 int32_t XFA_MapRotation(int32_t nRotation) { 366 int32_t XFA_MapRotation(int32_t nRotation) {
369 nRotation = nRotation % 360; 367 nRotation = nRotation % 360;
370 nRotation = nRotation < 0 ? nRotation + 360 : nRotation; 368 nRotation = nRotation < 0 ? nRotation + 360 : nRotation;
371 return nRotation; 369 return nRotation;
372 } 370 }
OLDNEW
« no previous file with comments | « xfa/fxfa/parser/xfa_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698