Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: xfa/fxfa/parser/xfa_parser_imp.cpp

Issue 1998873002: Clean up XFA code which causes warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fxfa/parser/xfa_object_imp.cpp ('k') | xfa/fxfa/parser/xfa_utils.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fxfa/parser/xfa_parser_imp.h" 7 #include "xfa/fxfa/parser/xfa_parser_imp.h"
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 case XFA_XDPPACKET_Xdc: 355 case XFA_XDPPACKET_Xdc:
356 return ParseAsXDPPacket_Xdc(pXMLDocumentNode, ePacketID); 356 return ParseAsXDPPacket_Xdc(pXMLDocumentNode, ePacketID);
357 case XFA_XDPPACKET_LocaleSet: 357 case XFA_XDPPACKET_LocaleSet:
358 case XFA_XDPPACKET_ConnectionSet: 358 case XFA_XDPPACKET_ConnectionSet:
359 case XFA_XDPPACKET_SourceSet: 359 case XFA_XDPPACKET_SourceSet:
360 return ParseAsXDPPacket_LocaleConnectionSourceSet(pXMLDocumentNode, 360 return ParseAsXDPPacket_LocaleConnectionSourceSet(pXMLDocumentNode,
361 ePacketID); 361 ePacketID);
362 default: 362 default:
363 return ParseAsXDPPacket_User(pXMLDocumentNode, ePacketID); 363 return ParseAsXDPPacket_User(pXMLDocumentNode, ePacketID);
364 } 364 }
365 return NULL;
366 } 365 }
367 CXFA_Node* CXFA_SimpleParser::ParseAsXDPPacket_XDP( 366 CXFA_Node* CXFA_SimpleParser::ParseAsXDPPacket_XDP(
368 CFDE_XMLNode* pXMLDocumentNode, 367 CFDE_XMLNode* pXMLDocumentNode,
369 XFA_XDPPACKET ePacketID) { 368 XFA_XDPPACKET ePacketID) {
370 if (!XFA_FDEExtension_MatchNodeName( 369 if (!XFA_FDEExtension_MatchNodeName(
371 pXMLDocumentNode, XFA_GetPacketByIndex(XFA_PACKET_XDP)->pName, 370 pXMLDocumentNode, XFA_GetPacketByIndex(XFA_PACKET_XDP)->pName,
372 XFA_GetPacketByIndex(XFA_PACKET_XDP)->pURI, 371 XFA_GetPacketByIndex(XFA_PACKET_XDP)->pURI,
373 XFA_GetPacketByIndex(XFA_PACKET_XDP)->eFlags)) { 372 XFA_GetPacketByIndex(XFA_PACKET_XDP)->eFlags)) {
374 return nullptr; 373 return nullptr;
375 } 374 }
(...skipping 1179 matching lines...) Expand 10 before | Expand all | Expand 10 after
1555 } 1554 }
1556 if (pPause && iCount > 500 && pPause->NeedToPauseNow()) { 1555 if (pPause && iCount > 500 && pPause->NeedToPauseNow()) {
1557 break; 1556 break;
1558 } 1557 }
1559 } 1558 }
1560 return (m_syntaxParserResult == FDE_XmlSyntaxResult::Error || 1559 return (m_syntaxParserResult == FDE_XmlSyntaxResult::Error ||
1561 m_NodeStack.GetSize() != 1) 1560 m_NodeStack.GetSize() != 1)
1562 ? -1 1561 ? -1
1563 : m_pParser->GetStatus(); 1562 : m_pParser->GetStatus();
1564 } 1563 }
OLDNEW
« no previous file with comments | « xfa/fxfa/parser/xfa_object_imp.cpp ('k') | xfa/fxfa/parser/xfa_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698