Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: xfa/fxbarcode/oned/BC_OnedUPCAReader.cpp

Issue 1998873002: Clean up XFA code which causes warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp ('k') | xfa/fxfa/app/xfa_ffdocview.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 // Original code is licensed as follows: 6 // Original code is licensed as follows:
7 /* 7 /*
8 * Copyright 2008 ZXing authors 8 * Copyright 2008 ZXing authors
9 * 9 *
10 * Licensed under the Apache License, Version 2.0 (the "License"); 10 * Licensed under the Apache License, Version 2.0 (the "License");
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 int32_t& e) { 82 int32_t& e) {
83 int32_t temp = m_ean13Reader->DecodeMiddle(row, startRange, resultString, e); 83 int32_t temp = m_ean13Reader->DecodeMiddle(row, startRange, resultString, e);
84 BC_EXCEPTION_CHECK_ReturnValue(e, 0); 84 BC_EXCEPTION_CHECK_ReturnValue(e, 0);
85 return temp; 85 return temp;
86 } 86 }
87 CFX_ByteString CBC_OnedUPCAReader::MaybeReturnResult(CFX_ByteString& result, 87 CFX_ByteString CBC_OnedUPCAReader::MaybeReturnResult(CFX_ByteString& result,
88 int32_t& e) { 88 int32_t& e) {
89 if (result[0] == '0') { 89 if (result[0] == '0') {
90 result.Delete(0); 90 result.Delete(0);
91 return result; 91 return result;
92 } else {
93 e = BCExceptionFormatException;
94 return "";
95 } 92 }
93 e = BCExceptionFormatException;
96 return ""; 94 return "";
97 } 95 }
OLDNEW
« no previous file with comments | « xfa/fxbarcode/oned/BC_OnedCode128Writer.cpp ('k') | xfa/fxfa/app/xfa_ffdocview.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698