Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: xfa/fde/xml/fde_xml_imp.cpp

Issue 1998873002: Clean up XFA code which causes warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fde/css/fde_cssstylesheet.cpp ('k') | xfa/fgas/layout/fgas_textbreak.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fde/xml/fde_xml_imp.h" 7 #include "xfa/fde/xml/fde_xml_imp.h"
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 m_pPrior->m_pNext = pNode; 347 m_pPrior->m_pNext = pNode;
348 } else if (m_pParent) { 348 } else if (m_pParent) {
349 m_pParent->m_pChild = pNode; 349 m_pParent->m_pChild = pNode;
350 } 350 }
351 m_pPrior = pNode; 351 m_pPrior = pNode;
352 return TRUE; 352 return TRUE;
353 } 353 }
354 default: 354 default:
355 return FALSE; 355 return FALSE;
356 } 356 }
357 return FALSE;
358 } 357 }
359 CFDE_XMLNode* CFDE_XMLNode::RemoveNodeItem(CFDE_XMLNode::NodeItem eItem) { 358 CFDE_XMLNode* CFDE_XMLNode::RemoveNodeItem(CFDE_XMLNode::NodeItem eItem) {
360 CFDE_XMLNode* pNode = NULL; 359 CFDE_XMLNode* pNode = NULL;
361 switch (eItem) { 360 switch (eItem) {
362 case CFDE_XMLNode::NextSibling: 361 case CFDE_XMLNode::NextSibling:
363 if (m_pNext) { 362 if (m_pNext) {
364 pNode = m_pNext; 363 pNode = m_pNext;
365 m_pNext = pNode->m_pNext; 364 m_pNext = pNode->m_pNext;
366 if (m_pNext) { 365 if (m_pNext) {
367 m_pNext->m_pPrior = this; 366 m_pNext->m_pPrior = this;
(...skipping 1705 matching lines...) Expand 10 before | Expand all | Expand 10 after
2073 m_BlockBuffer.DeleteTextChars(m_iDataLength - m_iEntityStart, FALSE); 2072 m_BlockBuffer.DeleteTextChars(m_iDataLength - m_iEntityStart, FALSE);
2074 m_pCurrentBlock = m_BlockBuffer.GetAvailableBlock(m_iIndexInBlock); 2073 m_pCurrentBlock = m_BlockBuffer.GetAvailableBlock(m_iIndexInBlock);
2075 m_iEntityStart = -1; 2074 m_iEntityStart = -1;
2076 } else { 2075 } else {
2077 if (m_iEntityStart < 0 && ch == L'&') { 2076 if (m_iEntityStart < 0 && ch == L'&') {
2078 m_iEntityStart = m_iDataLength - 1; 2077 m_iEntityStart = m_iDataLength - 1;
2079 } 2078 }
2080 } 2079 }
2081 m_pStart++; 2080 m_pStart++;
2082 } 2081 }
OLDNEW
« no previous file with comments | « xfa/fde/css/fde_cssstylesheet.cpp ('k') | xfa/fgas/layout/fgas_textbreak.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698