Clean up XFA code which causes warnings

xfa/fxfa/parser/xfa_utils_imp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/parser/xfa_utils.h"
 
 #include "core/fxcrt/include/fx_ext.h"
 #include "xfa/fde/xml/fde_xml_imp.h"
@@ skipping 237 matching lines @@
 FX_BOOL XFA_IsLayoutElement(XFA_ELEMENT eElement, FX_BOOL bLayoutContainer) {
   switch (eElement) {
     case XFA_ELEMENT_Draw:
     case XFA_ELEMENT_Field:
     case XFA_ELEMENT_InstanceManager:
       return !bLayoutContainer;
     case XFA_ELEMENT_Area:
     case XFA_ELEMENT_Subform:
     case XFA_ELEMENT_ExclGroup:
     case XFA_ELEMENT_SubformSet:
       return TRUE;

[Lei Zhang, 2016/05/20 03:48:02]

delete this line and fall through?

[Wei Li, 2016/05/20 16:33:15]

Done.

     case XFA_ELEMENT_PageArea:
     case XFA_ELEMENT_Form:
       return TRUE;
     default:
       return FALSE;
   }
-  return FALSE;
 }
 
 static const FX_DOUBLE fraction_scales[] = {0.1,
                                             0.01,
                                             0.001,
                                             0.0001,
                                             0.00001,
                                             0.000001,
                                             0.0000001,
                                             0.00000001,
@@ skipping 87 matching lines @@
 FX_DOUBLE XFA_ByteStringToDouble(const CFX_ByteStringC& szStringVal) {
   CFX_WideString wsValue = CFX_WideString::FromUTF8(szStringVal);
   return XFA_WideStringToDouble(wsValue);
 }
 
 int32_t XFA_MapRotation(int32_t nRotation) {
   nRotation = nRotation % 360;
   nRotation = nRotation < 0 ? nRotation + 360 : nRotation;
   return nRotation;
 }