Clean up XFA code which causes warnings

xfa/fxfa/fm2js/xfa_fm2jscontext.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/fm2js/xfa_fm2jscontext.h"
 
 #include <time.h>
 
@@ skipping 1273 matching lines @@
     pContext->ThrowScriptErrorMessage(XFA_IDS_INCORRECT_NUMBER_OF_METHOD,
                                       L"LocalTimeFmt");
   }
 }
 void CXFA_FM2JSContext::Num2Date(FXJSE_HOBJECT hThis,
                                  const CFX_ByteStringC& szFuncName,
                                  CFXJSE_Arguments& args) {
   int32_t argc = args.GetLength();
   if ((argc > 0) && (argc < 4)) {
     FX_BOOL bFlags = FALSE;
-    int32_t dDate;
+    int32_t dDate = 0;
     CFX_ByteString formatString;
     CFX_ByteString localString;
     FXJSE_HVALUE dateValue = GetSimpleHValue(hThis, args, 0);
     FXJSE_HVALUE formatValue = 0;
     FXJSE_HVALUE localValue = 0;
     if (HValueIsNull(hThis, dateValue)) {
       bFlags = TRUE;
     } else {
       dDate = (int32_t)HValueToFloat(hThis, dateValue);
       bFlags = dDate < 1;
@@ skipping 134 matching lines @@
     pContext->ThrowScriptErrorMessage(XFA_IDS_INCORRECT_NUMBER_OF_METHOD,
                                       L"Num2Date");
   }
 }
 void CXFA_FM2JSContext::Num2GMTime(FXJSE_HOBJECT hThis,
                                    const CFX_ByteStringC& szFuncName,
                                    CFXJSE_Arguments& args) {
   int32_t argc = args.GetLength();
   if ((argc > 0) && (argc < 4)) {
     FX_BOOL bFlags = FALSE;
-    int32_t iTime;
+    int32_t iTime = 0;
     CFX_ByteString formatString;
     CFX_ByteString localString;
     FXJSE_HVALUE timeValue = GetSimpleHValue(hThis, args, 0);
     FXJSE_HVALUE formatValue = 0;
     FXJSE_HVALUE localValue = 0;
     if (FXJSE_Value_IsNull(timeValue)) {
       bFlags = TRUE;
     } else {
       iTime = (int32_t)HValueToFloat(hThis, timeValue);
       if (FXSYS_abs(iTime) < 1.0) {
@@ skipping 41 matching lines @@
     pContext->ThrowScriptErrorMessage(XFA_IDS_INCORRECT_NUMBER_OF_METHOD,
                                       L"Num2GMTime");
   }
 }
 void CXFA_FM2JSContext::Num2Time(FXJSE_HOBJECT hThis,
                                  const CFX_ByteStringC& szFuncName,
                                  CFXJSE_Arguments& args) {
   int32_t argc = args.GetLength();
   if ((argc > 0) && (argc < 4)) {
     FX_BOOL bFlags = FALSE;
-    FX_FLOAT fTime;
+    FX_FLOAT fTime = 0.0f;
     CFX_ByteString formatString;
     CFX_ByteString localString;
     FXJSE_HVALUE timeValue = GetSimpleHValue(hThis, args, 0);
     FXJSE_HVALUE formatValue = 0;
     FXJSE_HVALUE localValue = 0;
     if (FXJSE_Value_IsNull(timeValue)) {
       bFlags = TRUE;
     } else {
       fTime = HValueToFloat(hThis, timeValue);
       if (FXSYS_fabs(fTime) < 1.0) {
@@ skipping 3331 matching lines @@
     pContext->ThrowScriptErrorMessage(XFA_IDS_INCORRECT_NUMBER_OF_METHOD,
                                       L"Space");
   }
 }
 void CXFA_FM2JSContext::Str(FXJSE_HOBJECT hThis,
                             const CFX_ByteStringC& szFuncName,
                             CFXJSE_Arguments& args) {
   int32_t argc = args.GetLength();
   if ((argc > 0) && (argc < 4)) {
     FX_BOOL bFlags = FALSE;
-    FX_FLOAT fNumber;
+    FX_FLOAT fNumber = 0.0f;
     int32_t iWidth = 10;
     int32_t iPrecision = 0;
     FXJSE_HVALUE numberValue = GetSimpleHValue(hThis, args, 0);
     FXJSE_HVALUE widthValue = 0;
     FXJSE_HVALUE precisionValue = 0;
     if (FXJSE_Value_IsNull(numberValue)) {
       bFlags = TRUE;
     } else {
       fNumber = HValueToFloat(hThis, numberValue);
     }
@@ skipping 290 matching lines @@
     pContext->ThrowScriptErrorMessage(XFA_IDS_INCORRECT_NUMBER_OF_METHOD,
                                       L"Upper");
   }
 }
 void CXFA_FM2JSContext::WordNum(FXJSE_HOBJECT hThis,
                                 const CFX_ByteStringC& szFuncName,
                                 CFXJSE_Arguments& args) {
   int32_t argc = args.GetLength();
   if ((argc > 0) && (argc < 4)) {
     FX_BOOL bFlags = FALSE;
-    FX_FLOAT fNumber;
+    FX_FLOAT fNumber = 0.0f;
     int32_t iIdentifier = 0;
     CFX_ByteString localeString;
     FXJSE_HVALUE numberValue = GetSimpleHValue(hThis, args, 0);
     FXJSE_HVALUE identifierValue = 0;
     FXJSE_HVALUE localeValue = 0;
     if (FXJSE_Value_IsNull(numberValue)) {
       bFlags = TRUE;
     } else {
       fNumber = HValueToFloat(hThis, numberValue);
     }
@@ skipping 285 matching lines @@
     IXFA_AppProvider* pAppProvider =
         pDoc->GetParser()->GetNotify()->GetAppProvider();
     if (!pAppProvider) {
       return;
     }
     CFX_ByteString bsURL;
     CFX_ByteString bsData;
     CFX_ByteString bsContentType;
     CFX_ByteString bsEncode;
     CFX_ByteString bsHeader;
-    FXJSE_HVALUE argOne;
-    FXJSE_HVALUE argTwo;
-    FXJSE_HVALUE argThree;
-    FXJSE_HVALUE argFour;
-    FXJSE_HVALUE argFive;
-    argOne = GetSimpleHValue(hThis, args, 0);
+    FXJSE_HVALUE argThree = nullptr;
+    FXJSE_HVALUE argFour = nullptr;
+    FXJSE_HVALUE argFive = nullptr;
+    FXJSE_HVALUE argOne = GetSimpleHValue(hThis, args, 0);
     HValueToUTF8String(argOne, bsURL);
-    argTwo = GetSimpleHValue(hThis, args, 1);
+    FXJSE_HVALUE argTwo = GetSimpleHValue(hThis, args, 1);
     HValueToUTF8String(argTwo, bsData);
     if (argc > 2) {
       argThree = GetSimpleHValue(hThis, args, 2);
       HValueToUTF8String(argThree, bsContentType);
     }
     if (argc > 3) {
       argFour = GetSimpleHValue(hThis, args, 3);
       HValueToUTF8String(argFour, bsEncode);
     }
     if (argc > 4) {
@@ skipping 43 matching lines @@
       return;
     }
     IXFA_AppProvider* pAppProvider =
         pDoc->GetParser()->GetNotify()->GetAppProvider();
     if (!pAppProvider) {
       return;
     }
     CFX_ByteString bsURL;
     CFX_ByteString bsData;
     CFX_ByteString bsEncode;
-    FXJSE_HVALUE argOne;
-    FXJSE_HVALUE argTwo;
-    FXJSE_HVALUE argThree;
-    argOne = GetSimpleHValue(hThis, args, 0);
+    FXJSE_HVALUE argThree = nullptr;
+    FXJSE_HVALUE argOne = GetSimpleHValue(hThis, args, 0);
     HValueToUTF8String(argOne, bsURL);
-    argTwo = GetSimpleHValue(hThis, args, 1);
+    FXJSE_HVALUE argTwo = GetSimpleHValue(hThis, args, 1);
     HValueToUTF8String(argTwo, bsData);
     if (argc > 2) {
       argThree = GetSimpleHValue(hThis, args, 2);
       HValueToUTF8String(argThree, bsEncode);
     }
     FX_BOOL bFlags = pAppProvider->PutRequestURL(
         CFX_WideString::FromUTF8(bsURL.AsStringC()),
         CFX_WideString::FromUTF8(bsData.AsStringC()),
         CFX_WideString::FromUTF8(bsEncode.AsStringC()));
     FXJSE_Value_Release(argOne);
@@ skipping 1644 matching lines @@
   CFX_WideString wsFormat;
   pAppProvider->LoadString(iStringID, wsFormat);
   CFX_WideString wsMessage;
   va_list arg_ptr;
   va_start(arg_ptr, iStringID);
   wsMessage.FormatV(wsFormat.c_str(), arg_ptr);
   va_end(arg_ptr);
   FXJSE_ThrowMessage(
       "", FX_UTF8Encode(wsMessage.c_str(), wsMessage.GetLength()).AsStringC());
 }