Use BufferContext + offset instead of BufferPointer.

Use BufferContext + offset instead of BufferPointer.

This lets us avoid creating tens of millions of BufferPointer instances
and makes DDC compilation about 6% faster.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/0f441fa3ea361ae6d9a88c07e29ce17c6e7d2a9d

[Paul Berry, 2016-05-19 22:12:32]

lgtm

https://codereview.chromium.org/1998833002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/flat_buffers.dart (right):

https://codereview.chromium.org/1998833002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/flat_buffers.dart:50: ByteData buf = new
ByteData.view(uint8List.buffer);
I think if we do:

ByteData buf = new ByteData.view(uint8List.buffer, uint8List.offsetInBytes)

then we ought to be able to get rid of the _offset field, since the offset will
automatically be accounted for by the native ByteData implementation.

https://codereview.chromium.org/1998833002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/flat_buffers.dart:57: return offset +
_getUint32(offset);
I think this should be:

return offset + _getUint32(_offset + offset);

(Of course, if we get rid of _offset, then it's correct as is)

https://codereview.chromium.org/1998833002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/flat_buffers.dart:848: //    _length ??=
bp._getUint32(offset);
Did you forget to delete this?

[scheglov, 2016-05-20 03:08:30]

Description was changed from

==========
Use BufferContext + offset instead of BufferPointer.

This lets us avoid creating tens of millions of BufferPointer instances
and makes DDC compilation about 6% faster.

R=paulberry@google.com
BUG=
==========

to

==========
Use BufferContext + offset instead of BufferPointer.

This lets us avoid creating tens of millions of BufferPointer instances
and makes DDC compilation about 6% faster.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/0f441fa3ea361ae6d9a88c07e29ce17c6e7d2a9d
==========

[scheglov, 2016-05-20 03:08:31]

Committed patchset #2 (id:20001) manually as
0f441fa3ea361ae6d9a88c07e29ce17c6e7d2a9d (presubmit successful).

[scheglov, 2016-05-20 03:08:52]

https://codereview.chromium.org/1998833002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/flat_buffers.dart (right):

https://codereview.chromium.org/1998833002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/flat_buffers.dart:50: ByteData buf = new
ByteData.view(uint8List.buffer);
On 2016/05/19 22:12:32, Paul Berry wrote:
> I think if we do:
> 
> ByteData buf = new ByteData.view(uint8List.buffer, uint8List.offsetInBytes)
> 
> then we ought to be able to get rid of the _offset field, since the offset
will
> automatically be accounted for by the native ByteData implementation.

Done.

https://codereview.chromium.org/1998833002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/flat_buffers.dart:57: return offset +
_getUint32(offset);
On 2016/05/19 22:12:32, Paul Berry wrote:
> I think this should be:
> 
> return offset + _getUint32(_offset + offset);
> 
> (Of course, if we get rid of _offset, then it's correct as is)

_getUint32() already applies _offset.

https://codereview.chromium.org/1998833002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/flat_buffers.dart:848: //    _length ??=
bp._getUint32(offset);
On 2016/05/19 22:12:32, Paul Berry wrote:
> Did you forget to delete this?

Don't remember already why made this change at all.
Restored to its original lazy state.