third_party/WebKit/Source/core/editing/EditingUtilities.cpp - Issue 1998783002: [IME] Fire 'compositionend' after 'textInput' event and all other DOM updates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Issue 1998783002: [IME] Fire 'compositionend' after 'textInput' event and all other DOM updates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add DCHECK for empty text, fix ImeTest.java Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/EditingUtilities.h ('k') | third_party/WebKit/Source/core/editing/InputMethodController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

index cb18baab752c2bf0e892b9e58210b55588075394..7417544fbd55309f90598fd83cc6b2853def8b94 100644

--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

@@ -1746,13 +1746,13 @@ DispatchEventResult dispatchBeforeInputInsertText(EventTarget* target, const Str

return target->dispatchEvent(beforeInputEvent);

}

-DispatchEventResult dispatchBeforeInputFromComposition(EventTarget* target, InputEvent::InputType inputType, const String& data)

+DispatchEventResult dispatchBeforeInputFromComposition(EventTarget* target, InputEvent::InputType inputType, const String& data, InputEvent::EventCancelable cancelable)

{

if (!RuntimeEnabledFeatures::inputEventEnabled())

return DispatchEventResult::NotCanceled;

if (!target)

return DispatchEventResult::NotCanceled;

- InputEvent* beforeInputEvent = InputEvent::createBeforeInput(inputType, data, InputEvent::EventCancelable::NotCancelable, InputEvent::EventIsComposing::IsComposing);

+ InputEvent* beforeInputEvent = InputEvent::createBeforeInput(inputType, data, cancelable, InputEvent::EventIsComposing::IsComposing);

return target->dispatchEvent(beforeInputEvent);

}