third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp - Issue 1998743002: Apply ScrLike truncation to base href attribute's URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp

Issue 1998743002: Apply ScrLike truncation to base href attribute's URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/security/xssAuditor/base-href-unterminated-expected.txt ('K') | « third_party/WebKit/LayoutTests/http/tests/security/xssAuditor/base-href-unterminated-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp b/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp

index bbf0cb144a1743287c419ee4a1eed420b1117a04..aabb158e0afc3729bf6b90e8bd1326735725c539 100644

--- a/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp

+++ b/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp

@@ -571,7 +571,7 @@ bool XSSAuditor::filterBaseToken(const FilterTokenRequest& request)

ASSERT(request.token.type() == HTMLToken::StartTag);

ASSERT(hasName(request.token, baseTag));

- return eraseAttributeIfInjected(request, hrefAttr);

+ return eraseAttributeIfInjected(request, hrefAttr, String(), SrcLikeAttributeTruncation);

}

bool XSSAuditor::filterFormToken(const FilterTokenRequest& request)