Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 199873003: gyp_skia: make default GYP_GENERATORS for each platform explicit (Closed)

Created:
6 years, 9 months ago by epoger
Modified:
6 years, 9 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

gyp_skia: make default GYP_GENERATORS for each platform explicit BUG=skia:2317 Committed: http://code.google.com/p/skia/source/detail?r=13883

Patch Set 1 #

Total comments: 2

Patch Set 2 : added cygwin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M gyp_skia View 1 3 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
epoger
PTAL https://codereview.chromium.org/199873003/diff/1/gyp_skia File gyp_skia (right): https://codereview.chromium.org/199873003/diff/1/gyp_skia#newcode83 gyp_skia:83: if not os.getenv(ENVVAR_GYP_GENERATORS): gyp already picks a default ...
6 years, 9 months ago (2014-03-20 19:15:26 UTC) #1
bungeman-skia
https://codereview.chromium.org/199873003/diff/1/gyp_skia File gyp_skia (right): https://codereview.chromium.org/199873003/diff/1/gyp_skia#newcode83 gyp_skia:83: if not os.getenv(ENVVAR_GYP_GENERATORS): On 2014/03/20 19:15:26, epoger wrote: > ...
6 years, 9 months ago (2014-03-20 19:20:49 UTC) #2
epoger
Added cygwin, PTAL
6 years, 9 months ago (2014-03-20 19:23:07 UTC) #3
bungeman-skia
lgtm
6 years, 9 months ago (2014-03-20 19:24:14 UTC) #4
epoger
The CQ bit was checked by epoger@google.com
6 years, 9 months ago (2014-03-20 19:24:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/199873003/2
6 years, 9 months ago (2014-03-20 19:24:27 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 19:59:11 UTC) #7
Message was sent while issue was closed.
Change committed as 13883

Powered by Google App Engine
This is Rietveld 408576698