Return E_C_T_OFFLINE when the device is offline

Return E_C_T_OFFLINE  when the device is offline

Future CL will add additional logic to return E_C_T_OFFLINE
when the device is effectively offline.

BUG=612883
Committed: https://crrev.com/20cf2cd3438a720195b78716f900c740a8d10b57
Cr-Commit-Position: refs/heads/master@{#395214}

[tbansal1, 2016-05-19 17:49:43]

Description was changed from

==========
Return E_C_T_OFFLINE when the device is offline

BUG=612883
==========

to

==========
Return E_C_T_OFFLINE  when the device is offline

Future CL will add additional logic to return E_C_T_OFFLINE
when the device is effectively offline.

BUG=612883
==========

[tbansal1, 2016-05-19 18:14:21]

tbansal@chromium.org changed reviewers:
+ bengr@chromium.org

[tbansal1, 2016-05-19 18:14:21]

This is a reland of https://codereview.chromium.org/1991933002/ which had to be
reverted due to dependence of test correctness on the actual network type
available to the test device.

PS#1 contains the original CL.
PS#2 contains fixes made to the tests, and also an additional check to make sure
that in future, this flakiness is caught earlier.

[tbansal1, 2016-05-19 18:21:36]

Patchset #2 (id:20001) has been deleted

[bengr, 2016-05-20 20:39:12]

lgtm

https://codereview.chromium.org/1998683003/diff/40001/net/nqe/network_quality...
File net/nqe/network_quality_estimator.cc (right):

https://codereview.chromium.org/1998683003/diff/40001/net/nqe/network_quality...
net/nqe/network_quality_estimator.cc:666:
NetworkQualityEstimator::EffectiveConnectionType
We might want to consider widening the scope of ECT to net::

[tbansal1, 2016-05-20 22:01:12]

Patchset #3 (id:60001) has been deleted

[tbansal1, 2016-05-20 22:27:46]

https://codereview.chromium.org/1998683003/diff/40001/net/nqe/network_quality...
File net/nqe/network_quality_estimator.cc (right):

https://codereview.chromium.org/1998683003/diff/40001/net/nqe/network_quality...
net/nqe/network_quality_estimator.cc:666:
NetworkQualityEstimator::EffectiveConnectionType
On 2016/05/20 20:39:12, bengr wrote:
> We might want to consider widening the scope of ECT to net::

May be in future. Currently, this is similar to NCN which also restricts
connection type to net::NCN scope.

[tbansal1, 2016-05-20 23:39:17]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-05-20 23:39:18]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org
Link to the patchset: https://codereview.chromium.org/1998683003/#ps80001
(title: "Rebased")

[commit-bot: I haz the power, 2016-05-20 23:39:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998683003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998683003/80001

[commit-bot: I haz the power, 2016-05-21 00:17:46]

Description was changed from

==========
Return E_C_T_OFFLINE  when the device is offline

Future CL will add additional logic to return E_C_T_OFFLINE
when the device is effectively offline.

BUG=612883
==========

to

==========
Return E_C_T_OFFLINE  when the device is offline

Future CL will add additional logic to return E_C_T_OFFLINE
when the device is effectively offline.

BUG=612883
==========

[commit-bot: I haz the power, 2016-05-21 00:17:47]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-05-21 00:19:04]

Description was changed from

==========
Return E_C_T_OFFLINE  when the device is offline

Future CL will add additional logic to return E_C_T_OFFLINE
when the device is effectively offline.

BUG=612883
==========

to

==========
Return E_C_T_OFFLINE  when the device is offline

Future CL will add additional logic to return E_C_T_OFFLINE
when the device is effectively offline.

BUG=612883

Committed: https://crrev.com/20cf2cd3438a720195b78716f900c740a8d10b57
Cr-Commit-Position: refs/heads/master@{#395214}
==========

[commit-bot: I haz the power, 2016-05-21 00:19:05]

Patchset 3 (id:??) landed as
https://crrev.com/20cf2cd3438a720195b78716f900c740a8d10b57
Cr-Commit-Position: refs/heads/master@{#395214}