ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc - Issue 1998653002: Make DesktopWindowTreeHostX11::ShouldWindowContentsBeTransparent() relies on argb visual flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Issue 1998653002: Make DesktopWindowTreeHostX11::ShouldWindowContentsBeTransparent() relies on argb visual flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and use ShouldWindowContentsBeTransparent Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

diff --git a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

index 14e3a578111af56b4d71cd2de0d2c8e36d7e6e17..c25f77d5462bbfb47158da63e9ff673be551dfa9 100644

--- a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

+++ b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

@@ -781,7 +781,7 @@ bool DesktopWindowTreeHostX11::ShouldUseNativeFrame() const {

}

bool DesktopWindowTreeHostX11::ShouldWindowContentsBeTransparent() const {

- return false;

+ return IsTranslucentWindowOpacitySupported();

}

void DesktopWindowTreeHostX11::FrameTypeChanged() {

@@ -937,7 +937,7 @@ bool DesktopWindowTreeHostX11::IsAnimatingClosed() const {

}

bool DesktopWindowTreeHostX11::IsTranslucentWindowOpacitySupported() const {

- return false;

+ return use_argb_visual_;

}

void DesktopWindowTreeHostX11::SizeConstraintsChanged() {

« no previous file with comments | « ui/views/test/widget_test_mac.mm ('k') | ui/views/widget/widget_unittest.cc » ('j') | ui/views/widget/widget_unittest.cc » ('J')