Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Issue 1998653002: Make DesktopWindowTreeHostX11::ShouldWindowContentsBeTransparent() relies on argb visual flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and use USE_X11 instead of OS_LINUX Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/test/widget_test_mac.mm ('k') | ui/views/widget/widget_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
diff --git a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
index 98f99f4ca391096ad4998e798bce674d3774eeb1..8e8c65f96a7e6d6229fa961a7f625eb0d6f6dfd6 100644
--- a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
+++ b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
@@ -781,7 +781,8 @@ bool DesktopWindowTreeHostX11::ShouldUseNativeFrame() const {
}
bool DesktopWindowTreeHostX11::ShouldWindowContentsBeTransparent() const {
- return false;
+ // Ensure consistency with SetWindowTransparency().
+ return use_argb_visual_;
sadrul 2016/06/13 15:13:17 DesktopWindowTreeHostWin::ShouldWindowContentsBeTr
Julien Isorce Samsung 2016/06/13 15:53:20 I think it should not rely on ShouldUseNativeFrame
}
void DesktopWindowTreeHostX11::FrameTypeChanged() {
« no previous file with comments | « ui/views/test/widget_test_mac.mm ('k') | ui/views/widget/widget_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698