Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1998553002: media: Replace wtf/Assertions.h macros in favor of base/logging.h macros (Closed)

Created:
4 years, 7 months ago by Srirama
Modified:
4 years, 7 months ago
Reviewers:
fs
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gavinp+loader_chromium.org, gasubic, haraken, Nate Chapin, loading-reviews_chromium.org, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, tyoshino+watch_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Replace wtf/Assertions.h macros in favor of base/logging.h macros Replace WTF_LOG macros with DVLOG in AutoplayExperimentHelper.cpp, HTMLTrackElement.cpp, TextTrackLoader.cpp and VTTRegion.cpp. BUG=596522 Committed: https://crrev.com/4c0107731d76ac0f1c0c8e4406eab568157eb146 Cr-Commit-Position: refs/heads/master@{#394762}

Patch Set 1 #

Total comments: 8

Patch Set 2 : address comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTrackElement.cpp View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp View 10 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/loader/TextTrackLoader.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Srirama
PTAL. Cleaned up few more media files.
4 years, 7 months ago (2016-05-19 08:09:48 UTC) #3
fs
https://codereview.chromium.org/1998553002/diff/1/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp File third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp (right): https://codereview.chromium.org/1998553002/diff/1/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp#newcode43 third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp:43: DVLOG(3) << "autoplay experiment set to " << m_mode; ...
4 years, 7 months ago (2016-05-19 11:05:36 UTC) #4
Srirama
https://codereview.chromium.org/1998553002/diff/1/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp File third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp (right): https://codereview.chromium.org/1998553002/diff/1/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp#newcode43 third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp:43: DVLOG(3) << "autoplay experiment set to " << m_mode; ...
4 years, 7 months ago (2016-05-19 12:14:54 UTC) #5
fs
lgtm
4 years, 7 months ago (2016-05-19 12:18:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998553002/20001
4 years, 7 months ago (2016-05-19 12:27:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/8396) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-19 12:29:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998553002/40001
4 years, 7 months ago (2016-05-19 12:41:02 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-19 14:09:43 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 14:10:56 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4c0107731d76ac0f1c0c8e4406eab568157eb146
Cr-Commit-Position: refs/heads/master@{#394762}

Powered by Google App Engine
This is Rietveld 408576698