WTF: Add support for std::initializer_list in HashSet.

WTF: Add support for std::initializer_list in HashSet.

BUG=610931
Committed: https://crrev.com/55822436aa44ad3b61c59c502b427ecd2d7d00db
Cr-Commit-Position: refs/heads/master@{#394736}

[Yuta Kitamura, 2016-05-19 08:01:02]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[Yuta Kitamura, 2016-05-19 08:01:13]

yutak@chromium.org changed reviewers:
+ tzik@chromium.org

[Yuta Kitamura, 2016-05-19 08:01:13]

yutak@chromium.org changed required reviewers:
+ tzik@chromium.org

[Yuta Kitamura, 2016-05-19 08:01:14]

PTAL

[commit-bot: I haz the power, 2016-05-19 08:01:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998543003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998543003/1

[tzik, 2016-05-19 08:59:57]

lgtm

https://codereview.chromium.org/1998543003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/HashSet.h (right):

https://codereview.chromium.org/1998543003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/HashSet.h:146: {
Can we reserveCapacity here?

[Yuta Kitamura, 2016-05-19 09:03:27]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2016-05-19 09:03:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/1998543003/#ps20001
(title: "Reserve capacity; add tests for duplicated elements.")

[commit-bot: I haz the power, 2016-05-19 09:03:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998543003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998543003/20001

[Yuta Kitamura, 2016-05-19 09:04:21]

https://codereview.chromium.org/1998543003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/HashSet.h (right):

https://codereview.chromium.org/1998543003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/HashSet.h:146: {
On 2016/05/19 08:59:57, tzik wrote:
> Can we reserveCapacity here?

Done.

[sof, 2016-05-19 09:21:25]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2016-05-19 09:21:26]

https://codereview.chromium.org/1998543003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/HashSet.h (right):

https://codereview.chromium.org/1998543003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/HashSet.h:156: clear();
Would

  HashSet set(elements);
  *this = std::move(set);
  return *this;

work and avoid some duplication?

[Yuta Kitamura, 2016-05-19 09:37:25]

The CQ bit was unchecked by yutak@chromium.org

[Yuta Kitamura, 2016-05-19 09:41:57]

I'll pitch the updated version straight to CQ (based on
tzik's approval), but please speak up if it doesn't LGTY.

https://codereview.chromium.org/1998543003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/HashSet.h (right):

https://codereview.chromium.org/1998543003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/HashSet.h:156: clear();
On 2016/05/19 09:21:26, sof wrote:
> Would
> 
>   HashSet set(elements);
>   *this = std::move(set);
>   return *this;
> 
> work and avoid some duplication?

Yeah, that's better. I'm fixing.

[Yuta Kitamura, 2016-05-19 09:43:14]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2016-05-19 09:43:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/1998543003/#ps40001
(title: "Simplify assignment.")

[commit-bot: I haz the power, 2016-05-19 09:43:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998543003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998543003/40001

[commit-bot: I haz the power, 2016-05-19 11:16:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-19 11:18:59]

Description was changed from

==========
WTF: Add support for std::initializer_list in HashSet.

BUG=610931
==========

to

==========
WTF: Add support for std::initializer_list in HashSet.

BUG=610931

Committed: https://crrev.com/55822436aa44ad3b61c59c502b427ecd2d7d00db
Cr-Commit-Position: refs/heads/master@{#394736}
==========

[commit-bot: I haz the power, 2016-05-19 11:19:00]

Patchset 3 (id:??) landed as
https://crrev.com/55822436aa44ad3b61c59c502b427ecd2d7d00db
Cr-Commit-Position: refs/heads/master@{#394736}