Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 199853004: Throw exception on invalid string length instead of OOM. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Throw exception on invalid string length instead of OOM. R=bmeurer@chromium.org BUG=349329 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=20112

Patch Set 1 #

Patch Set 2 : tests! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -91 lines) Patch
M src/api.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download
M src/factory.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/func-name-inferrer.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/isolate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/json-stringifier.h View 7 chunks +29 lines, -6 lines 0 comments Download
M src/parser.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 18 chunks +28 lines, -27 lines 0 comments Download
M src/uri.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-strings.cc View 1 1 chunk +6 lines, -13 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/string-oom-array-join.js View 1 1 chunk +7 lines, -7 lines 0 comments Download
A + test/mjsunit/string-oom-concat.js View 1 1 chunk +6 lines, -6 lines 0 comments Download
A test/mjsunit/string-oom-replace-global-regexp-with-string.js View 1 1 chunk +14 lines, -0 lines 0 comments Download
A test/mjsunit/string-oom-replace-regexp-global-with-function.js View 1 1 chunk +14 lines, -0 lines 0 comments Download
A + test/mjsunit/string-oom-slow-escape.js View 1 1 chunk +7 lines, -5 lines 0 comments Download
A + test/mjsunit/string-oom-slow-json-stringify.js View 1 1 chunk +6 lines, -7 lines 0 comments Download
A + test/mjsunit/string-oom-slow-replace-one-with-string.js View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + test/mjsunit/string-oom-slow-to-uppercase.js View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
This is what I have planned. Obviously I'll have to add some more tests (not ...
6 years, 9 months ago (2014-03-18 15:11:02 UTC) #1
Benedikt Meurer
LGTM if you add some more test cases.
6 years, 9 months ago (2014-03-19 06:15:15 UTC) #2
Yang
On 2014/03/19 06:15:15, Benedikt Meurer wrote: > LGTM if you add some more test cases. ...
6 years, 9 months ago (2014-03-19 14:52:38 UTC) #3
Yang
6 years, 9 months ago (2014-03-20 10:49:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20112 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698