Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: chrome/browser/extensions/service_worker_apitest.cc

Issue 1998473003: Disable ServiceWorkerPushMessagingTest.OnPush on chromeos (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/service_worker_apitest.cc
diff --git a/chrome/browser/extensions/service_worker_apitest.cc b/chrome/browser/extensions/service_worker_apitest.cc
index 08cc9ad314c12d8a2bb1b0dfe6957843a8dc27b8..912a371fd87f289296df58fc9359d05c3148c653 100644
--- a/chrome/browser/extensions/service_worker_apitest.cc
+++ b/chrome/browser/extensions/service_worker_apitest.cc
@@ -697,7 +697,13 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerTest,
<< message_;
}
-IN_PROC_BROWSER_TEST_F(ServiceWorkerPushMessagingTest, OnPush) {
+// Flaky on ChromiumOS bots. http://crbug.com/612673
+#if defined(OS_CHROMEOS)
+#define MAYBE_OnPush DISABLED_OnPush
+#else
+#define MAYBE_OnPush OnPush
+#endif
+IN_PROC_BROWSER_TEST_F(ServiceWorkerPushMessagingTest, MAYBE_OnPush) {
const Extension* extension = LoadExtensionWithFlags(
test_data_dir_.AppendASCII("service_worker/push_messaging"), kFlagNone);
ASSERT_TRUE(extension);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698