Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 1998453003: Remove Moz{,2}Pageset and its pcv1 benchmark (Closed)

Created:
4 years, 7 months ago by kouhei (in TOK)
Modified:
4 years, 7 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Moz{,2}Pageset and its pcv1 benchmark MozPageSet is currently only used on ChromeOS bots, and contains super old artificial tests inherited from Mozilla. Moz2PageSet isn't used in any telemetry benchmarks. Now speed-infra CrOS bots are capable of running regular page_sets like typical_25, remove the page set and its page cycler v1 benchmark per comment. BUG=606277 Committed: https://crrev.com/98f0b00ab26bf5994d40a82c2bf6c803523a2c3a Cr-Commit-Position: refs/heads/master@{#394646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -148 lines) Patch
M tools/perf/benchmarks/page_cycler.py View 1 chunk +0 lines, -12 lines 0 comments Download
D tools/perf/page_sets/page_cycler/moz.py View 1 chunk +0 lines, -68 lines 0 comments Download
D tools/perf/page_sets/page_cycler/moz2.py View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kouhei (in TOK)
4 years, 7 months ago (2016-05-19 00:40:03 UTC) #3
nednguyen
lgtm
4 years, 7 months ago (2016-05-19 00:42:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998453003/1
4 years, 7 months ago (2016-05-19 00:42:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 03:12:19 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 03:14:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98f0b00ab26bf5994d40a82c2bf6c803523a2c3a
Cr-Commit-Position: refs/heads/master@{#394646}

Powered by Google App Engine
This is Rietveld 408576698