Always install xfonts-mathml package if it is available.

Always install xfonts-mathml package if it is available.

It contains "Symbol" font used by gfx_unittests.

The package was effectively removed from install-build-deps in
https://codereview.chromium.org/1580663002. Looks like it doesn't exist in
Ubuntu 15.10. So use 'package_exists' check before attempting to install it.

R=dpranke@chromium.org
BUG=610784
Committed: https://crrev.com/278ff066e18d726f7273263c6e2b9c71a7722397
Cr-Commit-Position: refs/heads/master@{#394611}

[Vadim Sh., 2016-05-18 22:38:54]

PTAL

I don't know why the original CL replaced xfonts-mathml with fonts-stix. Based
on the list of files in them, they are not equivalent:

http://packages.ubuntu.com/trusty/all/xfonts-mathml/filelist
http://packages.ubuntu.com/trusty/all/fonts-stix/filelist

(but I know nothing about fonts in Ubuntu)

https://codereview.chromium.org/1998443002/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/1998443002/diff/1/build/install-build-deps.sh...
build/install-build-deps.sh:253: dev_list="${dev_list} fonts-indic"
making indent consistent with the rest of the file

[Dirk Pranke, 2016-05-18 22:41:11]

dpranke@chromium.org changed reviewers:
+ thestig@chromium.org, thomasanderson@chromium.org

[Dirk Pranke, 2016-05-18 22:41:11]

this looks good to me, but it might be good to get thestig@ or thomasanderson@
to double-check what happened, too.

[Daniel Erat, 2016-05-18 22:46:29]

derat@chromium.org changed reviewers:
+ derat@chromium.org

[Daniel Erat, 2016-05-18 22:46:30]

https://codereview.chromium.org/1998443002/diff/1/build/experimental/install-...
File build/experimental/install-build-deps.py (right):

https://codereview.chromium.org/1998443002/diff/1/build/experimental/install-...
build/experimental/install-build-deps.py:365: _packages_dev += ('fonts-stix',)
do you mind also removing these fonts-stix references? they were added in error,
as far as i can tell (assuming that no dependencies for a mathml font sneaked in
in the last three months...)

[Vadim Sh., 2016-05-18 22:49:31]

https://codereview.chromium.org/1998443002/diff/1/build/experimental/install-...
File build/experimental/install-build-deps.py (right):

https://codereview.chromium.org/1998443002/diff/1/build/experimental/install-...
build/experimental/install-build-deps.py:365: _packages_dev += ('fonts-stix',)
On 2016/05/18 22:46:30, Daniel Erat wrote:
> do you mind also removing these fonts-stix references? they were added in
error,
> as far as i can tell (assuming that no dependencies for a mathml font sneaked
in
> in the last three months...)

Done.

[Daniel Erat, 2016-05-18 22:51:30]

lgtm

thanks! presumably FontTest.GetActualFontNameForTesting (and other cases in
RenderTextTest that depend on a symbol font being present) when we update to a
version that doesn't have this package, but this seems fine for now.

[Lei Zhang, 2016-05-18 22:51:45]

Probably ok for now, but if xfonts-mathml has gone away in newer Ubuntu versions
and AFAICT there's no replace package, then what's the plan in the future when
Ubuntu 14.04 is obsolete? We'll deal with it when we get there?

[Daniel Erat, 2016-05-18 22:51:53]

On 2016/05/18 22:51:30, Daniel Erat wrote:
> lgtm
> 
> thanks! presumably FontTest.GetActualFontNameForTesting (and other cases in
> RenderTextTest that depend on a symbol font being present) when we update to a
> version that doesn't have this package, but this seems fine for now.

"... _will fail_ when we update ..."

[Daniel Erat, 2016-05-18 22:54:10]

On 2016/05/18 22:51:53, Daniel Erat wrote:
> On 2016/05/18 22:51:30, Daniel Erat wrote:
> > lgtm
> > 
> > thanks! presumably FontTest.GetActualFontNameForTesting (and other cases in
> > RenderTextTest that depend on a symbol font being present) when we update to
a
> > version that doesn't have this package, but this seems fine for now.
> 
> "... _will fail_ when we update ..."

a workable plan might involve instead installing fonts-opensymbol and then
updating tests to check for either "symbol" or "opensymbol".

[Vadim Sh., 2016-05-18 22:54:46]

On 2016/05/18 22:51:45, Lei Zhang wrote:
> Probably ok for now, but if xfonts-mathml has gone away in newer Ubuntu
versions
> and AFAICT there's no replace package, then what's the plan in the future when
> Ubuntu 14.04 is obsolete? We'll deal with it when we get there?

Whoever maintains tests that use Symbol font must pick a replacement package and
make sure all tests work with the new font. Then we'll update this file. 

I'm just a lowly infra engineer trying to fix broken GCE Precise images.

[Vadim Sh., 2016-05-18 22:56:36]

The CQ bit was checked by vadimsh@chromium.org

[commit-bot: I haz the power, 2016-05-18 22:57:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998443002/20001

[commit-bot: I haz the power, 2016-05-18 23:05:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 23:06:00]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Vadim Sh., 2016-05-18 23:07:44]

On 2016/05/18 23:06:00, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Can an owner review and give an l-g-t-m, please?

[Dirk Pranke, 2016-05-18 23:36:54]

On 2016/05/18 23:07:44, Vadim Sh. wrote:
> On 2016/05/18 23:06:00, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> Can an owner review and give an l-g-t-m, please?

Hm. I thought "looks good to me" worked.

lgtm.

[Vadim Sh., 2016-05-18 23:37:37]

The CQ bit was checked by vadimsh@chromium.org

[commit-bot: I haz the power, 2016-05-18 23:38:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998443002/20001

[commit-bot: I haz the power, 2016-05-19 00:06:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-19 00:08:10]

Description was changed from

==========
Always install xfonts-mathml package if it is available.

It contains "Symbol" font used by gfx_unittests.

The package was effectively removed from install-build-deps in
https://codereview.chromium.org/1580663002. Looks like it doesn't exist in
Ubuntu 15.10. So use 'package_exists' check before attempting to install it.

R=dpranke@chromium.org
BUG=610784
==========

to

==========
Always install xfonts-mathml package if it is available.

It contains "Symbol" font used by gfx_unittests.

The package was effectively removed from install-build-deps in
https://codereview.chromium.org/1580663002. Looks like it doesn't exist in
Ubuntu 15.10. So use 'package_exists' check before attempting to install it.

R=dpranke@chromium.org
BUG=610784

Committed: https://crrev.com/278ff066e18d726f7273263c6e2b9c71a7722397
Cr-Commit-Position: refs/heads/master@{#394611}
==========

[commit-bot: I haz the power, 2016-05-19 00:08:11]

Patchset 2 (id:??) landed as
https://crrev.com/278ff066e18d726f7273263c6e2b9c71a7722397
Cr-Commit-Position: refs/heads/master@{#394611}