Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1998433003:
Add scrolling power test. (Closed)
|
Created:
4 years, 7 months ago by erikchen Modified:
4 years, 6 months ago Reviewers:
nednguyen CC:
chromium-reviews, telemetry-reviews_chromium.org, charliea (OOO until 10-5) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiontelemetry: Add scrolling power test.
The test creates a page full of text and slowly scrolls it using
requestAnimationFrame.
BUG=616811
Committed: https://crrev.com/dd3bbf7f0f1cfac1ff91c49b19a1e8078d43ce7b
Cr-Commit-Position: refs/heads/master@{#397564}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : Move page. #
Messages
Total messages: 34 (16 generated)
Description was changed from ========== asdf Add scrolling power test. BUG= ========== to ========== asdf Add scrolling power test. BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
Description was changed from ========== asdf Add scrolling power test. BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Add scrolling power test. BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998433003/1
Description was changed from ========== Add scrolling power test. BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== telemetry: Add scrolling power test. The test creates a page full of text and slowly scrolls it using requestAnimationFrame. BUG=616811 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
erikchen@chromium.org changed reviewers: + nednguyen@google.com
nednguyen: Please review.
lgtm +Randy: you can add this to your power page sets so we can calibrate Erik's results and battor's result.
On 2016/06/02 18:22:45, nednguyen wrote: > lgtm > > +Randy: you can add this to your power page sets so we can calibrate Erik's > results and battor's result. Will do.
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998433003/20001
On 2016/06/02 18:25:18, rnephew (Reviews Here) wrote: > On 2016/06/02 18:22:45, nednguyen wrote: > > lgtm > > > > +Randy: you can add this to your power page sets so we can calibrate Erik's > > results and battor's result. > > Will do. For this CL though, isn't the standard practice to have the html of a page set be stored under tools/perf/page_sets/<page_set_name>/<html_name>.html?
On 2016/06/02 18:27:23, rnephew (Reviews Here) wrote: > On 2016/06/02 18:25:18, rnephew (Reviews Here) wrote: > > On 2016/06/02 18:22:45, nednguyen wrote: > > > lgtm > > > > > > +Randy: you can add this to your power page sets so we can calibrate Erik's > > > results and battor's result. > > > > Will do. > > For this CL though, isn't the standard practice to have the html of a page set > be stored under tools/perf/page_sets/<page_set_name>/<html_name>.html? I was just copying tools/perf/page_sets/dummy_page.html
On 2016/06/02 18:28:51, erikchen wrote: > On 2016/06/02 18:27:23, rnephew (Reviews Here) wrote: > > On 2016/06/02 18:25:18, rnephew (Reviews Here) wrote: > > > On 2016/06/02 18:22:45, nednguyen wrote: > > > > lgtm > > > > > > > > +Randy: you can add this to your power page sets so we can calibrate > Erik's > > > > results and battor's result. > > > > > > Will do. > > > > For this CL though, isn't the standard practice to have the html of a page set > > be stored under tools/perf/page_sets/<page_set_name>/<html_name>.html? > > I was just copying tools/perf/page_sets/dummy_page.html Yeah, I think thats the odd man out for the most part. Look at tough_animated_images_cases for example. The page_set is in tools/perf/page_sets/tough_animated_images_cases.py and the pages is at tools/perf/page_sets/tough_animated_images_cases/gifs.html
The CQ bit was unchecked by nednguyen@google.com
On 2016/06/02 18:31:20, rnephew (Reviews Here) wrote: > On 2016/06/02 18:28:51, erikchen wrote: > > On 2016/06/02 18:27:23, rnephew (Reviews Here) wrote: > > > On 2016/06/02 18:25:18, rnephew (Reviews Here) wrote: > > > > On 2016/06/02 18:22:45, nednguyen wrote: > > > > > lgtm > > > > > > > > > > +Randy: you can add this to your power page sets so we can calibrate > > Erik's > > > > > results and battor's result. > > > > > > > > Will do. > > > > > > For this CL though, isn't the standard practice to have the html of a page > set > > > be stored under tools/perf/page_sets/<page_set_name>/<html_name>.html? > > > > I was just copying tools/perf/page_sets/dummy_page.html > > Yeah, I think thats the odd man out for the most part. Look at > tough_animated_images_cases for example. > The page_set is in tools/perf/page_sets/tough_animated_images_cases.py and the > pages is at tools/perf/page_sets/tough_animated_images_cases/gifs.html +1 to Randy's comments. I wasn't follow the right practice in dummy_page.html, I will make another CL to address that page
On 2016/06/02 18:31:20, rnephew (Reviews Here) wrote: > On 2016/06/02 18:28:51, erikchen wrote: > > On 2016/06/02 18:27:23, rnephew (Reviews Here) wrote: > > > On 2016/06/02 18:25:18, rnephew (Reviews Here) wrote: > > > > On 2016/06/02 18:22:45, nednguyen wrote: > > > > > lgtm > > > > > > > > > > +Randy: you can add this to your power page sets so we can calibrate > > Erik's > > > > > results and battor's result. > > > > > > > > Will do. > > > > > > For this CL though, isn't the standard practice to have the html of a page > set > > > be stored under tools/perf/page_sets/<page_set_name>/<html_name>.html? > > > > I was just copying tools/perf/page_sets/dummy_page.html > > Yeah, I think thats the odd man out for the most part. Look at > tough_animated_images_cases for example. > The page_set is in tools/perf/page_sets/tough_animated_images_cases.py and the > pages is at tools/perf/page_sets/tough_animated_images_cases/gifs.html +1 to Randy's comments. I wasn't follow the right practice in dummy_page.html, I will make another CL to address that page
On 2016/06/02 18:35:41, nednguyen wrote: > On 2016/06/02 18:31:20, rnephew (Reviews Here) wrote: > > On 2016/06/02 18:28:51, erikchen wrote: > > > On 2016/06/02 18:27:23, rnephew (Reviews Here) wrote: > > > > On 2016/06/02 18:25:18, rnephew (Reviews Here) wrote: > > > > > On 2016/06/02 18:22:45, nednguyen wrote: > > > > > > lgtm > > > > > > > > > > > > +Randy: you can add this to your power page sets so we can calibrate > > > Erik's > > > > > > results and battor's result. > > > > > > > > > > Will do. > > > > > > > > For this CL though, isn't the standard practice to have the html of a page > > set > > > > be stored under tools/perf/page_sets/<page_set_name>/<html_name>.html? > > > > > > I was just copying tools/perf/page_sets/dummy_page.html > > > > Yeah, I think thats the odd man out for the most part. Look at > > tough_animated_images_cases for example. > > The page_set is in tools/perf/page_sets/tough_animated_images_cases.py and the > > pages is at tools/perf/page_sets/tough_animated_images_cases/gifs.html > > +1 to Randy's comments. I wasn't follow the right practice in dummy_page.html, I > will make another CL to address that page Done.
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/1998433003/#ps40001 (title: "Move page.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998433003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) linux_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) mac_retina_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998433003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
Description was changed from ========== telemetry: Add scrolling power test. The test creates a page full of text and slowly scrolls it using requestAnimationFrame. BUG=616811 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== telemetry: Add scrolling power test. The test creates a page full of text and slowly scrolls it using requestAnimationFrame. BUG=616811 ==========
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998433003/40001
Message was sent while issue was closed.
Description was changed from ========== telemetry: Add scrolling power test. The test creates a page full of text and slowly scrolls it using requestAnimationFrame. BUG=616811 ========== to ========== telemetry: Add scrolling power test. The test creates a page full of text and slowly scrolls it using requestAnimationFrame. BUG=616811 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== telemetry: Add scrolling power test. The test creates a page full of text and slowly scrolls it using requestAnimationFrame. BUG=616811 ========== to ========== telemetry: Add scrolling power test. The test creates a page full of text and slowly scrolls it using requestAnimationFrame. BUG=616811 Committed: https://crrev.com/dd3bbf7f0f1cfac1ff91c49b19a1e8078d43ce7b Cr-Commit-Position: refs/heads/master@{#397564} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/dd3bbf7f0f1cfac1ff91c49b19a1e8078d43ce7b Cr-Commit-Position: refs/heads/master@{#397564} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
