Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1998433002: Dart: Adds Interface and InterfaceRequest interfaces. (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 7 months ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Adds Interface and InterfaceRequest interfaces. This change ties the generated Proxies and Stubs together under shared Dart interfaces. This allows us to give tighter static types in the generated bindings. It also allows us to use interfaces that are more closely aligned with the Mojo concepts of Interface, and InterfaceRequest parameters in Mojo RPC. This is a breaking change: - The connectToService factory has been moved from the generated Proxy class to the generated interface class: new FooProxy.connectToService(...) => Foo.connectToService(...) - The serviceDescription static getter has moved from the generated Stub class tot he generated interface class: FooStub.serviceDescription => Foo.serviceDescription Otherwise existing code should continue to work as before. related #647 R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/02596a0415f2e785ce2475049d02c368e49a33ad

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Tighten types for interface encoding #

Patch Set 6 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8845 lines, -4825 lines) Patch
M benchmarks/mojo_rtt_benchmark/lib/echo_server.dart View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M examples/dart/echo_client/lib/main.dart View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M examples/dart/wget/lib/main.dart View 1 2 3 4 5 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/dart/apptests/dart_apptests/lib/src/echo_apptests.dart View 1 2 3 4 5 7 chunks +70 lines, -91 lines 0 comments Download
M mojo/dart/apptests/dart_apptests/lib/src/pingpong_apptests.dart View 1 2 3 4 5 2 chunks +55 lines, -62 lines 0 comments Download
M mojo/dart/apptests/dart_apptests/lib/src/service_describer_apptests.dart View 1 2 3 4 5 4 chunks +17 lines, -18 lines 0 comments Download
M mojo/dart/apptests/dart_apptests/lib/src/versioning_apptests.dart View 1 2 3 4 5 4 chunks +23 lines, -30 lines 0 comments Download
M mojo/dart/apptests/test_apps/echo/lib/main.dart View 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/dart/apptests/test_apps/echo_with_service_describer/lib/main.dart View 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/apptests/test_apps/pingpong/lib/main.dart View 1 2 3 4 5 5 chunks +29 lines, -35 lines 0 comments Download
M mojo/dart/apptests/test_apps/pingpong_target/lib/main.dart View 3 4 5 2 chunks +15 lines, -13 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart View 1 2 3 4 5 17 chunks +116 lines, -60 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/math/math_calculator.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/examples/echo.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_structs.mojom.dart View 1 2 3 4 5 10 chunks +59 lines, -31 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_unions.mojom.dart View 1 2 3 4 5 17 chunks +114 lines, -58 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/validation_test_interfaces.mojom.dart View 1 2 3 4 5 36 chunks +229 lines, -117 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/regression_tests/regression_tests.mojom.dart View 1 2 3 4 5 49 chunks +337 lines, -169 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_factory.mojom.dart View 1 2 3 4 5 27 chunks +129 lines, -73 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_interfaces.mojom.dart View 1 2 3 4 5 25 chunks +168 lines, -84 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_service.mojom.dart View 1 2 3 4 5 20 chunks +124 lines, -68 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart View 1 2 3 4 5 24 chunks +128 lines, -72 lines 0 comments Download
M mojo/dart/packages/mojo/lib/bindings.dart View 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/application.mojom.dart View 1 2 3 4 5 11 chunks +65 lines, -37 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/application_connector.mojom.dart View 1 2 3 4 5 11 chunks +65 lines, -37 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/bindings/types/service_describer.mojom.dart View 1 2 3 4 5 17 chunks +116 lines, -60 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/service_provider.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/shell.mojom.dart View 1 2 3 4 5 11 chunks +65 lines, -37 lines 0 comments Download
M mojo/dart/packages/mojo/lib/src/application.dart View 1 2 3 4 5 3 chunks +11 lines, -8 lines 0 comments Download
M mojo/dart/packages/mojo/lib/src/application_connection.dart View 1 2 3 4 5 2 chunks +8 lines, -9 lines 0 comments Download
M mojo/dart/packages/mojo/lib/src/codec.dart View 1 2 3 4 5 3 chunks +23 lines, -40 lines 0 comments Download
A mojo/dart/packages/mojo/lib/src/interfaces.dart View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
M mojo/dart/packages/mojo/lib/src/proxy.dart View 3 4 5 3 chunks +21 lines, -4 lines 0 comments Download
M mojo/dart/packages/mojo/lib/src/stub.dart View 1 2 3 4 5 3 chunks +9 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo/sources.gni View 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/activity/activity.mojom.dart View 1 2 3 4 5 26 chunks +172 lines, -88 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/authentication/authentication.mojom.dart View 1 2 3 4 5 9 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/contacts/contacts.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/http_server/http_server.mojom.dart View 1 2 3 4 5 17 chunks +116 lines, -60 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/http_server/http_server_factory.mojom.dart View 1 2 3 4 5 9 chunks +60 lines, -32 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/icu_data/icu_data.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/input/input.mojom.dart View 1 2 3 4 5 17 chunks +116 lines, -60 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/keyboard/keyboard.mojom.dart View 1 2 3 4 5 27 chunks +177 lines, -93 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/asset_bundle/asset_bundle.mojom.dart View 1 2 3 4 5 17 chunks +116 lines, -60 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/authenticating_url_loader_interceptor_meta_factory.mojom.dart View 1 2 3 4 5 9 chunks +61 lines, -33 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/camera.mojom.dart View 1 2 3 4 5 16 chunks +112 lines, -56 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/clipboard.mojom.dart View 1 2 3 4 5 9 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/content_handler.mojom.dart View 1 2 3 4 5 9 chunks +60 lines, -32 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/cookie_store.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/device_info.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/files/directory.mojom.dart View 1 2 3 4 5 13 chunks +64 lines, -36 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/files/file.mojom.dart View 1 2 3 4 5 14 chunks +64 lines, -36 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/files/files.mojom.dart View 1 2 3 4 5 9 chunks +60 lines, -32 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/geocoder.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/compositor.mojom.dart View 1 2 3 4 5 11 chunks +65 lines, -37 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/hit_tests.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/renderers.mojom.dart View 1 2 3 4 5 13 chunks +64 lines, -36 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/resources.mojom.dart View 1 2 3 4 5 9 chunks +57 lines, -29 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/scenes.mojom.dart View 1 2 3 4 5 20 chunks +120 lines, -64 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/scheduling.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/host_resolver.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/http_connection.mojom.dart View 1 2 3 4 5 17 chunks +115 lines, -59 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/http_server.mojom.dart View 1 2 3 4 5 9 chunks +61 lines, -33 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/location_service.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/audio_server.mojom.dart View 1 2 3 4 5 9 chunks +60 lines, -32 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/audio_track.mojom.dart View 1 2 3 4 5 12 chunks +64 lines, -36 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_demux.mojom.dart View 1 2 3 4 5 11 chunks +60 lines, -32 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_factory.mojom.dart View 1 2 3 4 5 19 chunks +83 lines, -55 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_player.mojom.dart View 1 2 3 4 5 9 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_sink.mojom.dart View 1 2 3 4 5 9 chunks +60 lines, -32 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_source.mojom.dart View 1 2 3 4 5 13 chunks +64 lines, -36 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_transport.mojom.dart View 1 2 3 4 5 26 chunks +172 lines, -88 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_type_converter.mojom.dart View 1 2 3 4 5 12 chunks +64 lines, -36 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/rate_control.mojom.dart View 1 2 3 4 5 9 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/seeking_reader.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/timeline_controller.mojom.dart View 1 2 3 4 5 22 chunks +124 lines, -68 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/native_viewport_event_dispatcher.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/navigation.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/network_service.mojom.dart View 1 2 3 4 5 25 chunks +92 lines, -64 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/service_registry.mojom.dart View 1 2 3 4 5 9 chunks +60 lines, -32 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/sharing.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/surfaces.mojom.dart View 1 2 3 4 5 18 chunks +116 lines, -60 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/tcp_bound_socket.mojom.dart View 1 2 3 4 5 11 chunks +64 lines, -36 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/tcp_connected_socket.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/tcp_server_socket.mojom.dart View 1 2 3 4 5 9 chunks +60 lines, -32 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/terminal/terminal.mojom.dart View 1 2 3 4 5 11 chunks +64 lines, -36 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/terminal/terminal_client.mojom.dart View 1 2 3 4 5 9 chunks +60 lines, -32 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/timelines.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/udp_socket.mojom.dart View 1 2 3 4 5 19 chunks +116 lines, -60 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/input_connection.mojom.dart View 1 2 3 4 5 17 chunks +116 lines, -60 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/input_dispatcher.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_associates.mojom.dart View 1 2 3 4 5 26 chunks +176 lines, -92 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_containers.mojom.dart View 1 2 3 4 5 21 chunks +124 lines, -68 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_manager.mojom.dart View 1 2 3 4 5 13 chunks +72 lines, -44 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_provider.mojom.dart View 1 2 3 4 5 9 chunks +62 lines, -34 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_token.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_trees.mojom.dart View 1 2 3 4 5 22 chunks +124 lines, -68 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/views.mojom.dart View 1 2 3 4 5 22 chunks +124 lines, -68 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/url_loader.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/url_loader_interceptor.mojom.dart View 1 2 3 4 5 17 chunks +116 lines, -60 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/url_response_disk_cache.mojom.dart View 1 2 3 4 5 9 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/web_socket.mojom.dart View 1 2 3 4 5 18 chunks +116 lines, -60 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/native_support/process.mojom.dart View 1 2 3 4 5 19 chunks +124 lines, -68 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/nfc/nfc.mojom.dart View 1 2 3 4 5 25 chunks +172 lines, -88 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/notifications/notifications.mojom.dart View 1 2 3 4 5 25 chunks +173 lines, -89 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/prediction/prediction.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/sensors/sensors.mojom.dart View 1 2 3 4 5 17 chunks +116 lines, -60 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/speech_recognizer/speech_recognizer.mojom.dart View 1 2 3 4 5 17 chunks +116 lines, -60 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/tracing/trace_provider_registry.mojom.dart View 1 2 3 4 5 9 chunks +60 lines, -32 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/tracing/tracing.mojom.dart View 1 2 3 4 5 25 chunks +172 lines, -88 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/vsync/vsync.mojom.dart View 1 2 3 4 5 8 chunks +56 lines, -28 lines 0 comments Download
M mojo/dart/unittests/embedder_tests/bindings_generation_test.dart View 3 4 5 1 chunk +1 line, -7 lines 0 comments Download
M mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl View 1 2 3 4 5 9 chunks +56 lines, -28 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_dart_generator.py View 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
zra
4 years, 7 months ago (2016-05-19 21:59:36 UTC) #5
Cutch
lgtm
4 years, 7 months ago (2016-05-20 17:43:50 UTC) #7
zra
4 years, 7 months ago (2016-05-20 21:00:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #6 (id:70001) manually as
02596a0415f2e785ce2475049d02c368e49a33ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698