Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 199843004: Chrome metro mode win7 emulation. (Closed)

Created:
6 years, 9 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 9 months ago
Reviewers:
zturner, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Chrome metro mode win7 emulation. It seems possible that we can run Ash (chrome metro) in Windows7 since we are using the GPU-direct path in Aura. In fact, we had something close to this that bitrotted because only the output (display) had common code with what we shipped but no commonality otherwise in two important regards - Input - Focus & Activation. Basically what we had it was a frankenstein between Ash and Desktop Aura that had the worst bugs from both and nobody cared to fix because a fix there would be mostly orthogonal from the two modes that we ship. This is an effort to address these issues. It uses COM / WinRT magic to try to reuse as much code as possible from the metro_viewer side, while trying to keep the browser side identical. In other to have that reuse, we need to emulate the host (microsoft) side of the metro environment. This patch is a start on that direction namely an emulation of a WinRT object known as "Windows.ApplicationModel.Core.CoreApplication" Which exposes a bunch of interfaces but only two we try to emulate. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258530

Patch Set 1 : move code #

Patch Set 2 : space #

Patch Set 3 : icorewindow and interop #

Total comments: 11

Patch Set 4 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+554 lines, -120 lines) Patch
M win8/metro_driver/metro_driver.cc View 4 chunks +40 lines, -26 lines 0 comments Download
M win8/metro_driver/metro_driver.gyp View 2 chunks +7 lines, -0 lines 0 comments Download
M win8/metro_driver/metro_driver_win7.cc View 1 2 3 3 chunks +507 lines, -94 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
cpu_(ooo_6.6-7.5)
Note, this can be manually tested under the debugger by starting chrome.exe -ServerName:DefaultBrowserServer You can ...
6 years, 9 months ago (2014-03-16 01:21:48 UTC) #1
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/199843004/diff/60001/win8/metro_driver/metro_driver_win7.cc File win8/metro_driver/metro_driver_win7.cc (right): https://codereview.chromium.org/199843004/diff/60001/win8/metro_driver/metro_driver_win7.cc#newcode461 win8/metro_driver/metro_driver_win7.cc:461: // So call me, maybe! I'll remove the silly ...
6 years, 9 months ago (2014-03-20 17:50:31 UTC) #2
zturner
https://codereview.chromium.org/199843004/diff/60001/win8/metro_driver/metro_driver.cc File win8/metro_driver/metro_driver.cc (right): https://codereview.chromium.org/199843004/diff/60001/win8/metro_driver/metro_driver.cc#newcode111 win8/metro_driver/metro_driver.cc:111: auto view_factory = mswr::Make<ChromeAppViewFactory>(core_app.Get()); I know this isn't your ...
6 years, 9 months ago (2014-03-20 18:14:13 UTC) #3
scottmg
That's pretty frightening! LGTM other than Zach's comments. I do worry somewhat that none of ...
6 years, 9 months ago (2014-03-20 20:05:04 UTC) #4
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/199843004/diff/60001/win8/metro_driver/metro_driver_win7.cc File win8/metro_driver/metro_driver_win7.cc (right): https://codereview.chromium.org/199843004/diff/60001/win8/metro_driver/metro_driver_win7.cc#newcode103 win8/metro_driver/metro_driver_win7.cc:103: // containing a CoreWindow which represents a surface that ...
6 years, 9 months ago (2014-03-20 22:13:13 UTC) #5
zturner
lgtm https://codereview.chromium.org/199843004/diff/60001/win8/metro_driver/metro_driver_win7.cc File win8/metro_driver/metro_driver_win7.cc (right): https://codereview.chromium.org/199843004/diff/60001/win8/metro_driver/metro_driver_win7.cc#newcode103 win8/metro_driver/metro_driver_win7.cc:103: // containing a CoreWindow which represents a surface ...
6 years, 9 months ago (2014-03-20 22:29:24 UTC) #6
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 9 months ago (2014-03-20 22:47:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/199843004/70001
6 years, 9 months ago (2014-03-20 22:50:08 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 11:39:09 UTC) #9
Message was sent while issue was closed.
Change committed as 258530

Powered by Google App Engine
This is Rietveld 408576698