Issue 199843003: Remove Apple-only GCC_WARN_ABOUT_MISSING_NEWLINE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199843003: Remove Apple-only GCC_WARN_ABOUT_MISSING_NEWLINE (Closed)

Created:
6 years, 9 months ago by bnoordhuis

Modified:
6 years, 8 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Visibility:
Public.

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	build/standalone.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

bnoordhuis

Remove GCC_WARN_ABOUT_MISSING_NEWLINE from standalone.gypi. -Wnewline-eof is an Apple extension, it makes it impossible to build ...

6 years, 9 months ago (2014-03-15 12:42:08 UTC) #1

Jakob Kummerow

6 years, 8 months ago (2014-04-02 12:55:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20435 (presubmit successful).