Require PLATFORM_FILE_BACKUP_SEMANTICS to open a directory

Require PLATFORM_FILE_BACKUP_SEMANTICS to open a directory

BUG=352429
R=cpu,brettw
TBR=brettw
NOTRY=true
NOTREECHECKS=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256975

[jschuh, 2014-03-14 02:19:57]

ptal

[Peter Kasting, 2014-03-14 02:23:10]

https://codereview.chromium.org/199843002/diff/1/base/platform_file_win.cc
File base/platform_file_win.cc (right):

https://codereview.chromium.org/199843002/diff/1/base/platform_file_win.cc#ne...
base/platform_file_win.cc:89: if (INVALID_HANDLE_VALUE != file){
Drive-by: Please write (file != INVALID_HANDLE_VALUE).  See the "Code
formatting" section of http://dev.chromium.org/developers/coding-style .

https://codereview.chromium.org/199843002/diff/1/base/platform_file_win.cc#ne...
base/platform_file_win.cc:93: DCHECK(GetFileInformationByHandle(file, &info));
Never do real work in a DCHECK.  In non-DCHECK builds this will get compiled to
nothing, and |info| will never be initialized.

Do something like this instead:

  bool success = ...;
  DCHECK(success);

[cpu_(ooo_6.6-7.5), 2014-03-14 02:23:25]

lgtm

[jschuh, 2014-03-14 02:55:09]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2014-03-14 02:55:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jschuh@chromium.org/199843002/20001

[commit-bot: I haz the power, 2014-03-14 02:57:09]

Change committed as 256975

[Peter Kasting, 2014-03-14 02:58:19]

https://codereview.chromium.org/199843002/diff/20001/base/platform_file_win.cc
File base/platform_file_win.cc (right):

https://codereview.chromium.org/199843002/diff/20001/base/platform_file_win.c...
base/platform_file_win.cc:89: if (INVALID_HANDLE_VALUE != file){
You didn't correct this style guide violation :(

[rvargas (doing something else), 2014-03-17 23:44:04]

Note that PlatformFile (and by extension CreateXXPlatformFile) is a deprecated
API (still used, but less each day).

You want to change file_win.h

[jschuh, 2014-03-18 14:29:19]

On 2014/03/17 23:44:04, rvargas wrote:
> Note that PlatformFile (and by extension CreateXXPlatformFile) is a deprecated
> API (still used, but less each day).
> 
> You want to change file_win.h

Was that maybe the wrong file nae? I don't see a file_win.h in the repo
anywhere.

[rvargas (doing something else), 2014-03-18 17:32:52]

On 2014/03/18 14:29:19, Justin Schuh wrote:
> On 2014/03/17 23:44:04, rvargas wrote:
> > Note that PlatformFile (and by extension CreateXXPlatformFile) is a
deprecated
> > API (still used, but less each day).
> > 
> > You want to change file_win.h
> 
> Was that maybe the wrong file nae? I don't see a file_win.h in the repo
> anywhere.

Yes, it was. base/files/file_win.cc :(

[jschuh, 2014-03-18 19:21:23]

On 2014/03/18 17:32:52, rvargas wrote:
> On 2014/03/18 14:29:19, Justin Schuh wrote:
> > On 2014/03/17 23:44:04, rvargas wrote:
> > > Note that PlatformFile (and by extension CreateXXPlatformFile) is a
> deprecated
> > > API (still used, but less each day).
> > > 
> > > You want to change file_win.h
> > 
> > Was that maybe the wrong file nae? I don't see a file_win.h in the repo
> > anywhere.
> 
> Yes, it was. base/files/file_win.cc :(

Thanks. I had no idea that even existed.