Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Issue 1998413002: Simplify import-w3c-tests: support exactly one argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
index 2551d9418429bd9568b6b9d41a8b25e65e0afe2f..44ca2e0ae5b66e1aa88de2887d0e8e561b10070d 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
@@ -35,8 +35,7 @@ from webkitpy.common.system.outputcapture import OutputCapture
from webkitpy.w3c.test_importer import TestImporter
-FAKE_SOURCE_DIR = '/blink/w3c'
-FAKE_REPO_DIR = '/blink'
+FAKE_SOURCE_REPO_DIR = '/blink'
FAKE_FILES = {'/mock-checkout/third_party/Webkit/LayoutTests/w3c/OWNERS': '',
'/blink/w3c/dir/README.txt': '',
@@ -67,7 +66,7 @@ class TestImporterTest(unittest.TestCase):
"abort: no repository found in '/Volumes/Source/src/wk/Tools/Scripts/webkitpy/w3c'"))
host.filesystem = MockFileSystem(files=FAKE_FILES)
- importer = TestImporter(host, FAKE_SOURCE_DIR, FAKE_REPO_DIR, self.options())
+ importer = TestImporter(host, FAKE_SOURCE_REPO_DIR, self.options())
oc = OutputCapture()
oc.capture_output()
@@ -77,18 +76,18 @@ class TestImporterTest(unittest.TestCase):
oc.restore_output()
def test_path_too_long_true(self):
- importer = TestImporter(MockHost(), FAKE_SOURCE_DIR, FAKE_REPO_DIR, self.options())
- self.assertTrue(importer.path_too_long(FAKE_REPO_DIR + '/' + ('x' * 150) + '.html'))
+ importer = TestImporter(MockHost(), FAKE_SOURCE_REPO_DIR, self.options())
+ self.assertTrue(importer.path_too_long(FAKE_SOURCE_REPO_DIR + '/' + ('x' * 150) + '.html'))
def test_path_too_long_false(self):
- importer = TestImporter(MockHost(), FAKE_SOURCE_DIR, FAKE_REPO_DIR, self.options())
- self.assertFalse(importer.path_too_long(FAKE_REPO_DIR + '/x.html'))
+ importer = TestImporter(MockHost(), FAKE_SOURCE_REPO_DIR, self.options())
+ self.assertFalse(importer.path_too_long(FAKE_SOURCE_REPO_DIR + '/x.html'))
def test_does_not_import_owner_files(self):
host = MockHost()
host.filesystem = MockFileSystem(files=FAKE_FILES)
- importer = TestImporter(host, FAKE_SOURCE_DIR, FAKE_REPO_DIR, self.options())
- importer.find_importable_tests(FAKE_REPO_DIR)
+ importer = TestImporter(host, FAKE_SOURCE_REPO_DIR, self.options())
+ importer.find_importable_tests()
self.assertEqual(importer.import_list,
[{'copy_list': [{'dest': 'README.txt', 'src': '/blink/w3c/dir/README.txt'}],
'dirname': '/blink/w3c/dir',
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698