Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1998393002:
(reland) cc: Cleanup tile manager a bit. (Closed)
Description(reland) cc: Cleanup tile manager a bit.
- Removed typedefs/aliases that only complicate things
- Moved AssignGpuMemoryToTiles to private
- Removed AssignGpuMemoryToTiles args.
- Made TileManager ctor public and removed TileManager::Create
R=enne, ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/ebcde2e2868ab7660430d3d702c0d7a52b38ad72
Cr-Commit-Position: refs/heads/master@{#395456}
Committed: https://crrev.com/31d54a10b96a14cbdb3250a53fc3be0f806c726b
Cr-Commit-Position: refs/heads/master@{#396888}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : rebase #
Messages
Total messages: 21 (12 generated)
Description was changed from ========== cc: Cleanup tile manager a bit. - Removed typedefs/using that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. R=enne, ericrk ========== to ========== cc: Cleanup tile manager a bit. - Removed typedefs/using that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== cc: Cleanup tile manager a bit. - Removed typedefs/using that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Cleanup tile manager a bit. - Removed typedefs/using that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== cc: Cleanup tile manager a bit. - Removed typedefs/using that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Cleanup tile manager a bit. - Removed typedefs/aliases that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Please take a look.
lgtm Thanks for the cleanup!
The CQ bit was checked by vmpstr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998393002/20001
Message was sent while issue was closed.
Description was changed from ========== cc: Cleanup tile manager a bit. - Removed typedefs/aliases that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Cleanup tile manager a bit. - Removed typedefs/aliases that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== cc: Cleanup tile manager a bit. - Removed typedefs/aliases that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Cleanup tile manager a bit. - Removed typedefs/aliases that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ebcde2e2868ab7660430d3d702c0d7a52b38ad72 Cr-Commit-Position: refs/heads/master@{#395456} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ebcde2e2868ab7660430d3d702c0d7a52b38ad72 Cr-Commit-Position: refs/heads/master@{#395456}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2006973004/ by isheriff@chromium.org. The reason for reverting is: Failed drmemory tests. see https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%2....
Message was sent while issue was closed.
Description was changed from ========== cc: Cleanup tile manager a bit. - Removed typedefs/aliases that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ebcde2e2868ab7660430d3d702c0d7a52b38ad72 Cr-Commit-Position: refs/heads/master@{#395456} ========== to ========== cc: Cleanup tile manager a bit. - Removed typedefs/aliases that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ebcde2e2868ab7660430d3d702c0d7a52b38ad72 Cr-Commit-Position: refs/heads/master@{#395456} ==========
Description was changed from ========== cc: Cleanup tile manager a bit. - Removed typedefs/aliases that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ebcde2e2868ab7660430d3d702c0d7a52b38ad72 Cr-Commit-Position: refs/heads/master@{#395456} ========== to ========== (reland) cc: Cleanup tile manager a bit. - Removed typedefs/aliases that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ebcde2e2868ab7660430d3d702c0d7a52b38ad72 Cr-Commit-Position: refs/heads/master@{#395456} ==========
The CQ bit was checked by vmpstr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ericrk@chromium.org Link to the patchset: https://codereview.chromium.org/1998393002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998393002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998393002/40001
Message was sent while issue was closed.
Description was changed from ========== (reland) cc: Cleanup tile manager a bit. - Removed typedefs/aliases that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ebcde2e2868ab7660430d3d702c0d7a52b38ad72 Cr-Commit-Position: refs/heads/master@{#395456} ========== to ========== (reland) cc: Cleanup tile manager a bit. - Removed typedefs/aliases that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ebcde2e2868ab7660430d3d702c0d7a52b38ad72 Cr-Commit-Position: refs/heads/master@{#395456} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== (reland) cc: Cleanup tile manager a bit. - Removed typedefs/aliases that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ebcde2e2868ab7660430d3d702c0d7a52b38ad72 Cr-Commit-Position: refs/heads/master@{#395456} ========== to ========== (reland) cc: Cleanup tile manager a bit. - Removed typedefs/aliases that only complicate things - Moved AssignGpuMemoryToTiles to private - Removed AssignGpuMemoryToTiles args. - Made TileManager ctor public and removed TileManager::Create R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ebcde2e2868ab7660430d3d702c0d7a52b38ad72 Cr-Commit-Position: refs/heads/master@{#395456} Committed: https://crrev.com/31d54a10b96a14cbdb3250a53fc3be0f806c726b Cr-Commit-Position: refs/heads/master@{#396888} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/31d54a10b96a14cbdb3250a53fc3be0f806c726b Cr-Commit-Position: refs/heads/master@{#396888} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
