EventDispatcher shouldn't always cancel on a hierarchy change

EventDispatcher shouldn't always cancel on a hierarchy change

Currently when a window is moved to a different parent we cancel
events. This is problematic for window dragging as we want to reparent
the window to ensure it's stacked on top of other windows.

The fix here isn't ideal, but I'm going to address the bigger issue as
part of 613646.

BUG=613646
TEST=covered by test
R=jonross@chromium.org

Committed: https://crrev.com/b863e7efb7ffcb6be025385c11d61b4b70b9ceee
Cr-Commit-Position: refs/heads/master@{#395145}

[jonross, 2016-05-20 18:55:30]

On 2016/05/20 18:27:07, sky wrote:

LGTM with minor nit

[sky, 2016-05-20 19:11:47]

Did the nit not make it?

On Fri, May 20, 2016 at 11:55 AM,  <jonross@chromium.org> wrote:
> On 2016/05/20 18:27:07, sky wrote:
>
> LGTM with minor nit
>
> https://codereview.chromium.org/1998323002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jonross, 2016-05-20 19:14:07]

https://codereview.chromium.org/1998323002/diff/1/components/mus/ws/event_dis...
File components/mus/ws/event_dispatcher_unittest.cc (right):

https://codereview.chromium.org/1998323002/diff/1/components/mus/ws/event_dis...
components/mus/ws/event_dispatcher_unittest.cc:1534: // Move |w11| to |w2| and
verify the mouse is still down, and |w2| has
Nit: Currently disagrees with the actual test, as we are keeping capture on w11.

[sky, 2016-05-20 19:25:20]

https://codereview.chromium.org/1998323002/diff/1/components/mus/ws/event_dis...
File components/mus/ws/event_dispatcher_unittest.cc (right):

https://codereview.chromium.org/1998323002/diff/1/components/mus/ws/event_dis...
components/mus/ws/event_dispatcher_unittest.cc:1534: // Move |w11| to |w2| and
verify the mouse is still down, and |w2| has
On 2016/05/20 19:14:07, jonross wrote:
> Nit: Currently disagrees with the actual test, as we are keeping capture on
w11.

Done.

[sky, 2016-05-20 19:25:43]

The CQ bit was checked by sky@chromium.org

[sky, 2016-05-20 19:25:43]

The patchset sent to the CQ was uploaded after l-g-t-m from jonross@chromium.org
Link to the patchset: https://codereview.chromium.org/1998323002/#ps20001
(title: "feedback")

[commit-bot: I haz the power, 2016-05-20 19:26:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998323002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998323002/20001

[commit-bot: I haz the power, 2016-05-20 20:01:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-20 20:03:11]

Description was changed from

==========
EventDispatcher shouldn't always cancel on a hierarchy change

Currently when a window is moved to a different parent we cancel
events. This is problematic for window dragging as we want to reparent
the window to ensure it's stacked on top of other windows.

The fix here isn't ideal, but I'm going to address the bigger issue as
part of 613646.

BUG=613646
TEST=covered by test
R=jonross@chromium.org
==========

to

==========
EventDispatcher shouldn't always cancel on a hierarchy change

Currently when a window is moved to a different parent we cancel
events. This is problematic for window dragging as we want to reparent
the window to ensure it's stacked on top of other windows.

The fix here isn't ideal, but I'm going to address the bigger issue as
part of 613646.

BUG=613646
TEST=covered by test
R=jonross@chromium.org

Committed: https://crrev.com/b863e7efb7ffcb6be025385c11d61b4b70b9ceee
Cr-Commit-Position: refs/heads/master@{#395145}
==========

[commit-bot: I haz the power, 2016-05-20 20:03:12]

Patchset 2 (id:??) landed as
https://crrev.com/b863e7efb7ffcb6be025385c11d61b4b70b9ceee
Cr-Commit-Position: refs/heads/master@{#395145}